Skip to content

Commit

Permalink
Merge pull request #463 from rramkumar1/master
Browse files Browse the repository at this point in the history
Support short names in CRD Meta. Allows for abbreviating CRD's in kubectl
  • Loading branch information
k8s-ci-robot authored Sep 4, 2018
2 parents e7907cd + d9405b8 commit 133bc74
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 11 deletions.
9 changes: 5 additions & 4 deletions pkg/crd/crd.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,11 @@ func crd(meta *CRDMeta) *apiextensionsv1beta1.CustomResourceDefinition {
Version: meta.version,
Scope: apiextensionsv1beta1.NamespaceScoped,
Names: apiextensionsv1beta1.CustomResourceDefinitionNames{
Kind: meta.kind,
ListKind: meta.listKind,
Plural: meta.plural,
Singular: meta.singular,
Kind: meta.kind,
ListKind: meta.listKind,
Plural: meta.plural,
Singular: meta.singular,
ShortNames: meta.shortNames,
},
},
}
Expand Down
16 changes: 9 additions & 7 deletions pkg/crd/meta.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,22 @@ type CRDMeta struct {
listKind string
singular string
plural string
shortNames []string
typeSource string
fn common.GetOpenAPIDefinitions
}

// NewCRDMeta creates a CRDMeta type which can be passed to a CRDHandler in
// order to create/ensure a CRD.
func NewCRDMeta(groupName, version, kind, listKind, singular, plural string) *CRDMeta {
func NewCRDMeta(groupName, version, kind, listKind, singular, plural string, shortNames ...string) *CRDMeta {
return &CRDMeta{
groupName: groupName,
version: version,
kind: kind,
listKind: listKind,
singular: singular,
plural: plural,
groupName: groupName,
version: version,
kind: kind,
listKind: listKind,
singular: singular,
plural: plural,
shortNames: shortNames,
}
}

Expand Down

0 comments on commit 133bc74

Please sign in to comment.