Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KEP for Pod Affinity NamespaceSelector #2251

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Add KEP for Pod Affinity NamespaceSelector #2251

merged 1 commit into from
Feb 3, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jan 12, 2021 •
edited
Loading

/sig scheduling

#2249

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 12, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jan 12, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jan 12, 2021

/assign @liggitt @Huang-Wei @wojtek-t @alculquicondor

@ahg-g ahg-g force-pushed the ahg-ns branch 4 times, most recently from 66ee7a6 to 70ba322 Compare January 13, 2021 19:18
@ahg-g ahg-g force-pushed the ahg-ns branch 2 times, most recently from bed326e to cd1bfd7 Compare January 13, 2021 21:10
wojtek-t
wojtek-t reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but I would like to see explicit approval from @liggitt first before approving

keps/sig-scheduling/2249-pod-affinity-namespace-selector/kep.yaml Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/kep.yaml Show resolved Hide resolved
@ahg-g ahg-g force-pushed the ahg-ns branch 2 times, most recently from fcd09c2 to 0e98f90 Compare February 1, 2021 15:23
Huang-Wei
Huang-Wei reviewed Feb 1, 2021
View reviewed changes
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
@ahg-g ahg-g force-pushed the ahg-ns branch 2 times, most recently from 91e5756 to 199ac0d Compare February 1, 2021 21:17
Huang-Wei
Huang-Wei reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. LGTM otherwise.

keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/2249-pod-affinity-namespace-selector/README.md Outdated Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Feb 2, 2021

a few clarifying comments, lgtm overall

@alculquicondor
Copy link
Member

looks good for squash

@ahg-g
Copy link
Member Author

ahg-g commented Feb 3, 2021

looks good for squash

@liggitt did you look at the latest diff? good to squash?

@liggitt
Copy link
Member

liggitt commented Feb 3, 2021

yeah, good to squash

@ahg-g
Copy link
Member Author

ahg-g commented Feb 3, 2021

Squashed, thanks all for the reviews.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 3, 2021

/lgtm
/approve PRR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@alculquicondor
Copy link
Member

LGTM

@ahg-g
Copy link
Member Author

ahg-g commented Feb 3, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3346fc0 into kubernetes:master Feb 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 3, 2021
@ahg-g ahg-g mentioned this pull request Feb 8, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@damemi damemi damemi left review comments

@Huang-Wei Huang-Wei Huang-Wei left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@liggitt liggitt liggitt left review comments

@devdattakulkarni devdattakulkarni devdattakulkarni left review comments

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
9 participants
@ahg-g @Huang-Wei @alculquicondor @liggitt @wojtek-t @k8s-ci-robot @devdattakulkarni @damemi @johnbelamaric