Support recovery from volume expansion failure

[gnufied]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allow users to recover from volume expansion failure
• Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR): https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/1790-recover-resize-failure/README.md
• Primary contact (assignee): @gnufied
• Responsible SIGs: sig-storage
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.32
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
    • Add KEP for recovering from volume expansion failure. #1516
    • KEP-1790: Add the acknowledgement under the Test Plan section. #4102
  • Code (k/k) update PR(s):
    • 1.23 Recover expansion failure kubernetes#106154
    • 1.28 Update api recovery apis kubernetes#116335
  • Docs (k/website) update PR(s):
• Beta
  • KEP (k/enhancements) update PR(s):
    • 1.24 KEP 1790: Update recover resize failure KEP for going beta. #3188
    • 1.32 Move recover from volume expansion feature to beta #4849
  • Code (k/k) update PR(s):
    • 1.32 Move RecoverVolumeExpansionFailure feature to beta kubernetes#128342
  • Docs (k/website) update PR(s):
    • 1.32 Mark RecoverVolumeExpansionFailure as beta website#48532
• Stable
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):

[gnufied]

/sig storage

[palnabarun]

/milestone v1.19

[palnabarun]

/stage alpha

[palnabarun]

@gnufied -- Can you please link to all the implementation PR's here - k/k or otherwise? 🙂

---

The current release schedule is:

• Monday, April 13: Week 1 - Release cycle begins
• Tuesday, May 19: Week 6 - Enhancements Freeze
• Thursday, June 25: Week 11 - Code Freeze
• Thursday, July 9: Week 14 - Docs must be completed and reviewed
• Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

[mikejoh]

Hello, @gnufied ! 👋 I'm one of the v1.19 Docs shadows. Does this enhancement work planned for v1.19 require any new docs (or modifications to existing docs)?

This is a friendly reminder that we're looking for a PR against kubernetes/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Regards,
Mikael.

[palnabarun]

Can you please link to all the implementation PR's here - k/k or otherwise?

@gnufied -- Pinging back as a friendly reminder for the above. 🙂

[gnufied]

@palnabarun thanks for the reminder. there isn't one yet.

[gnufied]

PR that implements necessary API changes and updates quota calculation code - kubernetes/kubernetes#91976

[mikejoh]

Hi @gnufied! Friendly reminder regarding that docs placeholder PR against kubernetes/website (branch dev-1.19). The deadline for this have been pushed to Friday the 19th of June. Let me know if you have any questions!

[palnabarun]

Hi @gnufied -- just wanted to check in about the progress of the enhancement.

The release timeline has been revised recently, more details of which can be found here.

Please let me know if you have any questions. 🙂

---

The revised release schedule is:

• Thursday, July 9th: Week 13 - Code Freeze
• Thursday, July 16th: Week 14 - Docs must be completed and reviewed
• Tuesday, August 25th: Week 20 - Kubernetes v1.19.0 released

[gnufied]

Docs PR - kubernetes/website#21920

[palnabarun]

Hi @gnufied 👋, I see that kubernetes/kubernetes#91976 and kubernetes/kubernetes#92770 yet to be merged. Do you think that they will be merged before the Code Freeze on Thursday, July 9th?

Thank you. 🙂

---

Code Freeze begins on Thursday, July 9th EOD PST

[annajung]

Hi @gnufied 👋 docs shadow here. Just a quick reminder to get your doc PR ready for review (Remove WIP/rebased/all ready to go) by EOD. Thank you!

[gnufied]

@annajung done. thank you.

[palnabarun]

@gnufied -- Please note that tomorrow is Code Freeze.

If the enhancement misses the code freeze, you will need to file an Exception Request in order to get this back into 1.19.

---

Code Freeze begins on Thursday, July 9th EOD PST

[kikisdeliveryservice]

I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20

/milestone 1.20

[k8s-ci-robot]

@kikisdeliveryservice: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21]

Use /milestone clear to clear the milestone.

In response to this:

I spoke to @gnufied this evening as since all of the related PRs have not merged he would like to defer this to 1.20

/milestone 1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

/milestone v1.20

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[carlory]

/remove-lifecycle rotten

[xing-yang]

/milestone v1.32

[jenshu]

Hello @gnufied 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage beta for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• The Release Signoff Checklist section of the KEP readme should be updated with the checklist items from the latest template
• Can you please make sure to add a Design Details section according to the template, with all the sub-sections (Test Plan, Graduation Criteria, Upgrade/Downgrade, Version Skew). (It looks like you currently do have a couple of these sections, just in a different order)
• Can you please make sure all the questions from the template are answered (or at least have an entry) under Monitoring Requirements and Scalability? There is one question from each section that's currently missing.
• In the kep.yaml, the latest-milestone needs to be updated to v1.32. It looks like that will be taken care of once this open PR merges.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[gnufied]

@jenshu I have addressed ^ concerns in my PR.PTAL

[jenshu]

@gnufied thank you! The PR looks good, can you just add one more thing to be complete: Copy over the checklist item

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

and Prerequisite testing updates (if applicable) from the Test Plan template?

[gnufied]

@jenshu done btw.

[jenshu]

Hi @gnufied, thanks for making the kep updates, everything looks good and I've updated the status to tracked for enhancements freeze!

[rdalbuquerque]

Hello @gnufied 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[rdalbuquerque]

Hi @gnufied , just a reminder to open a draft PR following the steps here.

Thanks

[gnufied]

Draft PR - kubernetes/website#48532

[wrkode]

👋 Hi there, William here from v1.32 Comms
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[jenshu]

Hey again @gnufied 👋, v1.32 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• Move RecoverVolumeExpansionFailure feature to beta kubernetes#128342

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[jenshu]

Hello @gnufied 👋, v1.32 Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

• Move RecoverVolumeExpansionFailure feature to beta kubernetes#128342

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!