Update gulp-sass dependency so that it compiles on OSX #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue with the package that prevented it from compilation on OSX, see: sass/node-sass#1086
|
AFAIK the linked issue was related to io.js v3.x only. It didn't occur in node v0.12 and was fixed before v4.0.0 release. |
|
@markogresak That's interesting. Previous version did not compile on osx yosemite with xcode 7, node 5 and npm 3. But anyway, this PR fixes the issue. |
|
There is a chance that the previous gulp-sass version was using an older version of node-sass, I remember that there were some issues in the past. |
|
LGTM |
bryk
added a commit
that referenced
this pull request
Nov 10, 2015
Update gulp-sass dependency so that it compiles on OSX
anvithks
pushed a commit
to anvithks/k8s-dashboard
that referenced
this pull request
Apr 10, 2020
Sync up development with master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the package that prevented it from compilation on OSX, see: sass/node-sass#1086