Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating with the new sig-windows TLs #5386

Merged
merged 1 commit into from
Jan 15, 2021
Merged

updating with the new sig-windows TLs #5386

merged 1 commit into from
Jan 15, 2021

Conversation

michmike
Copy link
Contributor

@michmike michmike commented Jan 5, 2021

I am leaving VMware to join a Nuvalence.io and as a result I am scaling down my involvement in Kubernetes and Open Source. I have been the chair in Sig-Windows since inception for the past 5 years and it has been a blast. This community has been great and welcomed Windows, enabling us to get to Alpha, Beta, and to a Stable release.

I will definitely be a huge Kubernetes and CNCF ecosystem user moving forward.

Congratulations to @jayunit100 and @jsturtevant on being the two new TLs on SIG-Windows.
@benmoss thank you for your contributions getting us to stable. you will be missed.
cc: @marosset

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jan 5, 2021
@benmoss
Copy link
Member

benmoss commented Jan 5, 2021 •
edited
Loading

Congrats @michmike @jayunit100 and @jsturtevant!

@marosset
Copy link
Contributor

marosset commented Jan 5, 2021

/lgtm

We'll miss you @michmike.
Best of luck with your new gig!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@cblecker
Copy link
Member

cblecker commented Jan 5, 2021

Hello everyone!

I don't see any mention of leadership changes out to the sig-windows mailing list. Where was this discussed?

For reference, there's a checklist of steps here.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2021
@michmike
Copy link
Contributor Author

michmike commented Jan 5, 2021 •
edited
Loading

@cblecker I had asked Jorge if there was a process and he was not aware of one. we didn't know. i will email the right aliases
we did do a lazy consensus for the two new TLs in multiple community meetings for sig-windows

@cblecker
Copy link
Member

cblecker commented Jan 5, 2021

@michmike Sounds great! Thank you!

ddebroy
ddebroy reviewed Jan 6, 2021
View reviewed changes
Copy link
Member

@ddebroy ddebroy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

we will miss you @michmike . Thanks for your leadership and contributions!

@jayunit100
Copy link
Member

Thanks mike will miss you homie

@michmike
Copy link
Contributor Author

@cblecker lazy consensus deadline is over. can we merge this PR?

This was referenced Jan 14, 2021
Merged
Merged
Merged
@michmike
Copy link
Contributor Author

@marosset can you please review?

@marosset
Copy link
Contributor

@marosset can you please review?

I did 9 days ago :)

happy to again
/lgtm
/approve

@mrbobbytables
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, michmike, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2021
@marosset
Copy link
Contributor

@cblecker Do you mind if we remove the hold and merge this now that we've followed the following the steps in the doc you linked?

@mrbobbytables
Copy link
Member

It's been long enough 👍
I forgot to remove the hold earlier

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1af0c65 into kubernetes:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddebroy ddebroy ddebroy left review comments

@marosset marosset Awaiting requested review from marosset

Assignees

@marosset marosset

@ddebroy ddebroy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@michmike @benmoss @marosset @cblecker @jayunit100 @mrbobbytables @k8s-ci-robot @ddebroy