Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document process for proposing changes to SIG/WG/UG leadership #5291

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Document process for proposing changes to SIG/WG/UG leadership #5291

merged 1 commit into from
Nov 11, 2020

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Nov 3, 2020

Fixes kubernetes/steering#179

This PR adds a light-weight process for proposing changes to SIG/WG/UG leadership. This will help in creating a consistent process for feedback from the community around leadership changes.

/hold
for review + steering approval

cc @kubernetes/steering-committee

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and liggitt November 3, 2020 09:46
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2020
@nikhita nikhita added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Nov 3, 2020
@nikhita nikhita mentioned this pull request Nov 3, 2020
Closed
@nikhita nikhita force-pushed the leadership-changes branch from f588fc1 to bf860a9 Compare November 3, 2020 11:13
liggitt
liggitt reviewed Nov 3, 2020
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for putting together a checklist for this. just had a couple comments

contributors/chairs-and-techleads/leadership-changes.md Outdated Show resolved Hide resolved
contributors/chairs-and-techleads/leadership-changes.md Outdated Show resolved Hide resolved
contributors/chairs-and-techleads/leadership-changes.md Outdated Show resolved Hide resolved
mrbobbytables
mrbobbytables reviewed Nov 3, 2020
View reviewed changes
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a good summary of what's generally done to start. A follow-up to do either in this doc or another one is outline what needs to be done to rotate out of all the various communication properties.

contributors/chairs-and-techleads/leadership-changes.md Show resolved Hide resolved
contributors/chairs-and-techleads/leadership-changes.md Outdated Show resolved Hide resolved
@nikhita nikhita force-pushed the leadership-changes branch from bf860a9 to 1a7f701 Compare November 3, 2020 15:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2020
@nikhita
Copy link
Member Author

nikhita commented Nov 3, 2020

Addressed feedback. PTAL.

@nikhita nikhita force-pushed the leadership-changes branch from 1a7f701 to 424e9d4 Compare November 3, 2020 15:49
@mrbobbytables
Copy link
Member

/lgtm
Thanks @nikhita :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@nikhita nikhita mentioned this pull request Nov 3, 2020
Merged
@liggitt
Copy link
Member

liggitt commented Nov 4, 2020

/lgtm

@dims
Copy link
Member

dims commented Nov 4, 2020

@nikhita let's add a bit more per @ehashman 's comments. LGTM otherwise

@nikhita nikhita force-pushed the leadership-changes branch from 424e9d4 to 35ec66d Compare November 4, 2020 15:00
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2020
irvifa
irvifa reviewed Nov 4, 2020
View reviewed changes
Copy link
Member

@irvifa irvifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2020
@justaugustus justaugustus mentioned this pull request Nov 4, 2020
Closed
39 tasks
@justaugustus
Copy link
Member

@ehashman -- for some additional bits and maybe some inspiration (since SIG Release is transitioning some roles as well)...

SIG Release has a few issue templates that could be helpful:

@justaugustus
Copy link
Member

/lgtm
(as a Chair)

Thanks for adding this!

@nikhita nikhita force-pushed the leadership-changes branch from 35ec66d to c8757b6 Compare November 5, 2020 08:19
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
@nikhita nikhita force-pushed the leadership-changes branch from c8757b6 to edae858 Compare November 5, 2020 08:20
@nikhita nikhita mentioned this pull request Nov 5, 2020
Open
@dims
Copy link
Member

dims commented Nov 5, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2020
ehashman
ehashman approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@ehashman ehashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@derekwaynecarr
Copy link
Member

/lgtm

@nikhita
Copy link
Member Author

nikhita commented Nov 11, 2020

Going to cancel the hold since we have many LGTMs. Let's merge and iterate if further changes are needed.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit e55b6dd into kubernetes:master Nov 11, 2020
@nikhita nikhita deleted the leadership-changes branch November 11, 2020 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irvifa irvifa irvifa left review comments

@mrbobbytables mrbobbytables mrbobbytables left review comments

@derekwaynecarr derekwaynecarr derekwaynecarr left review comments

@liggitt liggitt liggitt left review comments

@ehashman ehashman ehashman approved these changes

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@justaugustus justaugustus

@liggitt liggitt

@ehashman ehashman

@derekwaynecarr derekwaynecarr

@mrbobbytables mrbobbytables

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heads up to community over lead changes in SIGs/WGs
9 participants
@nikhita @mrbobbytables @liggitt @dims @justaugustus @k8s-ci-robot @derekwaynecarr @ehashman @irvifa