Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] Reintroduce seeding of math/rand source #2121

Merged
merged 2 commits into from
Feb 20, 2023
Merged

[occm] Reintroduce seeding of math/rand source #2121

merged 2 commits into from
Feb 20, 2023

Conversation

pierreprinetti
Copy link
Member

@pierreprinetti pierreprinetti commented Feb 20, 2023 •
edited
Loading

In Go v1.20, rand.Seed is deprecated and math/rand's is automatically seeded. However, that doesn't happen in Go v1.19 that is used to build this branch.

With this change, the global source for math/rand is seeded again in main.go.

In a separate commit, this PR bumps golangci-lint to v1.51.2, which handles the deprecation more gracefully.

Partially reverts #2102

What this PR does / why we need it:
rand.Seed was prematurely removed in a previous commit.

Which issue this PR fixes(if applicable):
fixes #2120

Release note:

NONE

@pierreprinetti
[occm] Revert seeding of math/rand source
b91cc4f 
In Go v1.20, `rand.Seed` is deprecated and `math/rand`'s is
automatically seeded. However, that doesn't happen in Go v1.19 that is
used to build this branch.

With this commit, the global source for `math/rand` is seeded again in
`main.go`.
@pierreprinetti
go-lint: Upgrade staticcheck to v0.4.2
1d20917 
which handles deprecations more gracefully.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pierreprinetti. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2023
@pierreprinetti
Copy link
Member Author

/cherry-pick release-1.26
/cc @zetaab @jichenjc

@pierreprinetti pierreprinetti changed the title Fix rand [occm] Revert seeding of math/rand source Feb 20, 2023
@pierreprinetti pierreprinetti changed the title [occm] Revert seeding of math/rand source [occm] Reintroduce seeding of math/rand source Feb 20, 2023
@zetaab
Copy link
Member

zetaab commented Feb 20, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2023
zetaab
zetaab approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit bd05a95 into kubernetes:master Feb 20, 2023
@pierreprinetti pierreprinetti deleted the fix_rand branch February 20, 2023 21:08
This was referenced Feb 20, 2023
Merged
Merged
m-bull pushed a commit to stackhpc/cloud-provider-openstack that referenced this pull request Feb 23, 2023
@pierreprinetti @m-bull
[occm] Reintroduce seeding of math/rand source (kubernetes#2121)
b2abb59 
* [occm] Revert seeding of math/rand source

In Go v1.20, `rand.Seed` is deprecated and `math/rand`'s is
automatically seeded. However, that doesn't happen in Go v1.19 that is
used to build this branch.

With this commit, the global source for `math/rand` is seeded again in
`main.go`.

* go-lint: Upgrade staticcheck to v0.4.2

which handles deprecations more gracefully.
m-bull pushed a commit to stackhpc/cloud-provider-openstack that referenced this pull request Feb 23, 2023
@pierreprinetti @m-bull
[occm] Reintroduce seeding of math/rand source (kubernetes#2121)
f9f01e0 
* [occm] Revert seeding of math/rand source

In Go v1.20, `rand.Seed` is deprecated and `math/rand`'s is
automatically seeded. However, that doesn't happen in Go v1.19 that is
used to build this branch.

With this commit, the global source for `math/rand` is seeded again in
`main.go`.

* go-lint: Upgrade staticcheck to v0.4.2

which handles deprecations more gracefully.
@pierreprinetti pierreprinetti mentioned this pull request Jun 12, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@ramineni ramineni Awaiting requested review from ramineni

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[occm] Rand not being initialised any more with a seed
3 participants
@pierreprinetti @k8s-ci-robot @zetaab