Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test gate #2100

Merged
merged 4 commits into from
Feb 17, 2023
Merged

fix test gate #2100

merged 4 commits into from
Feb 17, 2023

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Feb 16, 2023

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2023
@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/test openstack-cloud-controller-manager-e2e-test

@zetaab zetaab changed the title wip: fix testgate wip: fix test gate Feb 16, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 16, 2023
This was referenced Feb 16, 2023
Merged
Merged
@zetaab zetaab changed the title wip: fix test gate fix test gate Feb 16, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2023
@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

cc @jichenjc @kayrus devstack installation is now working with these changes. Please review

This was referenced Feb 16, 2023
Closed
Closed
@kayrus
Copy link
Contributor

kayrus commented Feb 16, 2023

@zetaab I don't have permissions to review in this repo. However I cherry-picked your changes into my branch, but it still failing: #2090 (comment)

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023 •
edited
Loading

@kayrus there is something else broken in manila

also interesting:

pyopenssl 22.0.0 requires cryptography>=35.0, but you have cryptography 3.3.2 which is incompatible.

3.3.2 is perhaps too old? is that typo, should it be 33.2 or something?

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023 •
edited
Loading

I try to remove that, because we cannot really use that old libraries.. it starts to fail another libs

/retest-required

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/test openstack-cloud-csi-cinder-e2e-test

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/test openstack-cloud-csi-cinder-sanity-test
/test openstack-cloud-csi-manila-sanity-test

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/test openstack-cloud-csi-manila-e2e-test

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/test openstack-cloud-csi-cinder-e2e-test
/test openstack-cloud-csi-cinder-sanity-test
/test openstack-cloud-csi-manila-sanity-test
/test openstack-cloud-csi-manila-e2e-test

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/retest

2 similar comments
@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/retest

@zetaab
Copy link
Member Author

zetaab commented Feb 16, 2023

/retest

@jichenjc
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@jichenjc
Copy link
Contributor

/override openstack-cloud-csi-manila-e2e-test

@k8s-ci-robot
Copy link
Contributor

@jichenjc: Overrode contexts on behalf of jichenjc: openstack-cloud-csi-manila-e2e-test

In response to this:

/override openstack-cloud-csi-manila-e2e-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit c397cab into kubernetes:master Feb 17, 2023
@zetaab zetaab deleted the fixgate branch February 17, 2023 06:33
@jichenjc jichenjc mentioned this pull request Feb 18, 2023
Merged
k8s-ci-robot pushed a commit that referenced this pull request Feb 18, 2023
@zetaab
Automated cherry pick of #2100: fix testgate (#2101)
16889df 
* fix testgate

* update golint, remove deprecated BuildNameToCertificate method

* remove cryptography override

* update secretstorage

* downgrade e2e test version
k8s-ci-robot pushed a commit that referenced this pull request Feb 18, 2023
@zetaab
Automated cherry pick of #2100: fix testgate (#2102)
48e06c6 
* fix testgate

* update golint, remove deprecated BuildNameToCertificate method

* use zed

* remove cryptography override

* update secretstorage
@pierreprinetti pierreprinetti mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zetaab @kayrus @jichenjc @k8s-ci-robot