Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize VPA release 1.3.0. #7768

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jm-franc
Copy link
Contributor

Updates docs, deployments, scripts for the VPA 1.3.0 release.

Marks VPA 1.3.0 as compatible with Kubernetes 1.28+ (verified by running "hack/run-e2e-tests.sh full-vpa" with GKE 1.28.15-gke.1342000).

What type of PR is this?

/kind feature

What this PR does / why we need it:

Finalizes the VPA release 1.3.0
#7731

Updates docs, deployments, scripts for the VPA 1.3.0 release.

kubernetes#7731

Marks VPA 1.3.0 as compatible with Kubernetes 1.28+ (verified by running
"hack/run-e2e-tests.sh full-vpa" with GKE 1.28.15-gke.1342000).
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/vertical-pod-autoscaler labels Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jm-franc
Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @jm-franc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 25, 2025
@jm-franc
Copy link
Contributor Author

/assign @raywainman

@robotarmy
Copy link

robotarmy commented Jan 26, 2025

I am excited to try this vertical-pod-autoscaler. Looks fascinating!!

If it helps I can confirm that the patch on master to add an extra [ ] ala [[ ... || ...]] in vertical-pod-autoscaler/hack/vpa-process-yamls.sh functions correctly and allows the currently broken 1.2.2 tag to function.

I can also confirm this branch installs correctly and the install script functions again.

I haven't verified further. Thank you for all your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants