[cluster-autoscaler-release-1.32] fix: add --leader-elect flags back by reverting https://github.com/kubernetes/autoscaler/pull/7233 #7764
Conversation
…bernetes#7761) * fix: move leader elect flag binding above InitFlags() * Revert kubernetes#7233 kubernetes#7233 broke `--leader-elect` flag by introducing `--lease-resource-name` that is redundant with `--leader-elect-resource-name` * fix: move leader election flag binding above flag parsing which happens in kube_flag.InitFlags() --------- Co-authored-by: Daniel Kłobuszewski <danielmk@google.com>
|
Hi @idebeijer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: idebeijer, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a221e41
into
kubernetes:cluster-autoscaler-release-1.32
What type of PR is this?
/kind bug
Manual cherry-pick of #7761
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #7668 on
cluster-autoscaler-release-1.32Special notes for your reviewer:
This also includes adding a comment to hopefully prevent bug from happening again (#7763)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: