-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error details to autoscaling backoff. #6327
Add error details to autoscaling backoff. #6327
Conversation
|
Welcome @walidghallab! |
f76f0e3
to
989f164
Compare
ec92182
to
c114758
Compare
dbc2b4a
to
9e0beb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything apart from the 2 structs I mention in one comment LGTM, just some minor comments. Still need to understand the structs
9e0beb7
to
e8b21d9
Compare
e8b21d9
to
8c78783
Compare
92d5838
to
e5ef663
Compare
e5ef663
to
7320849
Compare
Change-Id: I3b5c62ba13c2e048ce2d7170016af07182c11eee
7320849
to
cf6176f
Compare
Thanks for addressing the comments! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: towca, walidghallab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds more detailed error information to backoff interface & implementation.
This is needed as it will allow getting this info easily to show them as a reason for backoff.
Which issue(s) this PR fixes:
#6318
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: