fix: alicloud the function NodeGroupForNode return nil

[guopeng0]

What type of PR is this?

/kind bug

What this PR does / why we need it:

I noticed an issue in the implementation of the NodeGroupForNode function in the alicloud provider of the cluster-autoscaler project. This issue results in the function sometimes returning nil for nodes in a specific nodeGroup.

Currently, the implementation regenerates the cache data and calls Alibaba Cloud to query all instances when a specified instance is not found. However, the DescribeScalingInstances function has default values of pageSize=10 and pageNumber=1, which only returns a subset of the data.

To address this issue, I have made the following modifications:
Modify the code logic to perform multiple queries based on the TotalCount of response information, ensuring the complete set of instances in the nodeGroup is returned.
I am a frequent user of cluster-autoscaler and have thoroughly tested and validated these modifications on Alibaba Cloud.

The error in this function can lead to inaccurate nodeGroup healthy status, resulting in scaling issues.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: guopeng0 / name: guopeng (11c4b66, 3e555b5)

[k8s-ci-robot]

Welcome @guopeng0!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[guopeng0]

@x13n @BigDarkClown
hi
Could you kindly review my pull request and provide your feedback and suggestions? Thank you!

[vadasambar]

/label area/provider/alicloud

[k8s-ci-robot]

@vadasambar: The label(s) /label area/provider/alicloud cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label area/provider/alicloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vadasambar]

Looks like I can't add the area/provider/alicloud label. @ringtail you might want to take a look at this.

[vadasambar]

Just in case, I will do a first pass tomorrow. Thank you for the PR @guopeng0! The description you wrote is easy to understand.

/assign vadasambar

[vadasambar]

/lgtm
/approve

@guopeng0 can you please squash the commits into a single commit?

@x13n , @BigDarkClown can we get an approve on this PR 🙏

[ringtail]

/LGTM

[k8s-ci-robot]

@ringtail: changing LGTM is restricted to collaborators

In response to this:

/LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ringtail]

Thanks @guopeng0 .

[x13n]

/approve

(Based on @ringtail's lgtm above.)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guopeng0, vadasambar, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [x13n]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment