Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add revisionHistoryLimit override to cluster-autoscaler #6292

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Nov 16, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allows overriding the revisionHistoryLimit on the cluster autoscaler deployment. The default value is 10 which is the implicit Kubernetes default.

Which issue(s) this PR fixes:

#5701 was previously opened to add this but the submitter cancelled the PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @bodgit!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2023
@vadasambar
Copy link
Member

/assign vadasambar

@vadasambar
Copy link
Member

image

@vadasambar
Copy link
Member

Thank you for the PR @bodgit
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2023
@vadasambar
Copy link
Member

@mwielgus , @gjtempleton need approval.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@Shubham82
Copy link
Contributor

@bodgit please resolve the merge conflicts, so that the failed test will be passed.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 17, 2023
@bodgit
Copy link
Contributor Author

bodgit commented Nov 17, 2023

@Shubham82 done

@Shubham82
Copy link
Contributor

@bodgit you need to bump the chart version so that the failed test case will be passed.

@bodgit bodgit force-pushed the chart-enhancements branch from b5e2e8a to 2ca15aa Compare November 17, 2023 10:02
@bodgit
Copy link
Contributor Author

bodgit commented Nov 17, 2023

@bodgit you need to bump the chart version so that the failed test case will be passed.

Sorry, second attempt. Should be fixed now.

@Shubham82
Copy link
Contributor

@bodgit you need to bump the chart version so that the failed test case will be passed.

Sorry, second attempt. Should be fixed now.

Don't be sorry for it.

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
@bodgit bodgit force-pushed the chart-enhancements branch from 2ca15aa to db80037 Compare November 17, 2023 12:46
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
@gjtempleton
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bodgit, gjtempleton, vadasambar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8de60c9 into kubernetes:master Nov 17, 2023
@bodgit bodgit deleted the chart-enhancements branch November 17, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants