-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add revisionHistoryLimit override to cluster-autoscaler #6292
Conversation
Welcome @bodgit! |
/assign vadasambar |
Thank you for the PR @bodgit |
@mwielgus , @gjtempleton need approval. |
@bodgit please resolve the merge conflicts, so that the failed test will be passed. |
@Shubham82 done |
@bodgit you need to bump the chart version so that the failed test case will be passed. |
b5e2e8a
to
2ca15aa
Compare
Sorry, second attempt. Should be fixed now. |
Don't be sorry for it. |
/lgtm |
Signed-off-by: Matt Dainty <matt@bodgit-n-scarper.com>
2ca15aa
to
db80037
Compare
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bodgit, gjtempleton, vadasambar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allows overriding the
revisionHistoryLimit
on the cluster autoscaler deployment. The default value is 10 which is the implicit Kubernetes default.Which issue(s) this PR fixes:
#5701 was previously opened to add this but the submitter cancelled the PR.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: