Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: balancer RBAC permission to update balancer status #5964

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Jul 18, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Prior to change:

I0718 02:32:46.477651       1 controller.go:144] Processing balancer kube-public/balancer-poc
W0718 02:32:46.489904       1 controller.go:194] Failed to update status of balancer kube-public/balancer-poc: balancers.balancer.x-k8s.io "balancer-poc" is forbidden: User "system:serviceaccount:kube-system:balancer-controller" cannot update resource "balancers/status" in API group "balancer.x-k8s.io" in the namespace "kube-public"
I0718 02:32:46.489999       1 event.go:294] "Event occurred" object="kube-public/balancer-poc" fieldPath="" kind="Balancer" apiVersion="balancer.x-k8s.io/v1alpha1" type="Warning" reason="StatusNotUpdated" message="balancers.balancer.x-k8s.io \"balancer-poc\" is forbidden: User \"system:serviceaccount:kube-system:balancer-controller\" cannot update resource \"balancers/status\" in API group \"balancer.x-k8s.io\" in the namespace \"kube-public\""

After change:

I0718 02:32:50.215554       1 controller.go:144] Processing balancer kube-public/balancer-poc
I0718 02:32:50.234116       1 controller.go:144] Processing balancer kube-public/balancer-poc
I0718 02:33:01.491710       1 controller.go:144] Processing balancer kube-public/balancer-poc
I0718 02:33:02.558944       1 controller.go:144] Processing balancer kube-public/balancer-poc
I0718 02:33:02.571374       1 scale.go:102] Scaling deployments/kube-public/balancer-poc-us-west-2a to 3

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix: balancer RBAC permission to update balancer status

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kgolab July 18, 2023 02:43
@k8s-ci-robot k8s-ci-robot requested a review from mwielgus July 18, 2023 02:43
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a7i, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 71dca88 into kubernetes:master Aug 4, 2023
@a7i a7i deleted the balancer-rbac-update-status branch August 4, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/balancer cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants