Replace BuildTestContainer with use of builder

[kwiesmueller]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Resolves a code TODO by replacing uses of BuildTestContainer with use of the builder directly.

Which issue(s) this PR fixes:

Fixes code TODO

Special notes for your reviewer:

I was resolving the TODO and generally think it might have helped clean things up, but would like to get some feedback if we all agree this change makes sense.
I can see it both ways that having this helper made sense. If so we should just remove the TODO instead.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @jbartosik

[jbartosik]

/retest

Test failure seems unrelated to the PR:

W0627 20:22:16.992770   40599 clusterstate.go:444] AcceptableRanges have not been populated yet. Skip checking
--- FAIL: TestBinpackingLimiter (0.00s)
    common.go:404: 
        	Error Trace:	/home/runner/work/autoscaler/autoscaler/go/src/k8s.io/autoscaler/cluster-autoscaler/core/test/common.go:404
        	            				/home/runner/work/autoscaler/autoscaler/go/src/k8s.io/autoscaler/cluster-autoscaler/core/scaleup/orchestrator/orchestrator.go:173
        	            				/home/runner/work/autoscaler/autoscaler/go/src/k8s.io/autoscaler/cluster-autoscaler/core/scaleup/orchestrator/orchestrator_test.go:855
        	Error:      	did not find expansionOptionToChoose %+v
        	Test:       	TestBinpackingLimiter
        	Messages:   	&{GroupName:ng1 SizeChange:1}
    orchestrator_test.go:858: 
        	Error Trace:	/home/runner/work/autoscaler/autoscaler/go/src/k8s.io/autoscaler/cluster-autoscaler/core/scaleup/orchestrator/orchestrator_test.go:858
        	Error:      	Should be true
        	Test:       	TestBinpackingLimiter

[jbartosik]

Looks good to me

One idea I have is that we're calling resource.MustParse each time we call WithMemRequest and similar functions (in existing code too). What do you think about changing the builder to take a string input instead?

(this is a strict improvement so if you think it's better to merge as-is let's do that)

[mwielgus]

/retest

[kwiesmueller]

If we always use a string for the quantity it makes sense to simplify, agreed.
Would do that in a follow-up.

[kwiesmueller]

Retest didn't trigger, trying again.

/retest
/test

[k8s-ci-robot]

@kwiesmueller: No presubmit jobs available for kubernetes/autoscaler@master

In response to this:

Retest didn't trigger, trying again.

/retest
/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jbartosik]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbartosik, kwiesmueller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS [jbartosik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jbartosik]

If we always use a string for the quantity it makes sense to simplify, agreed.

It seems so to me.