doks: use providerID for node.ID #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @andrewsykim |
5fcc6bc to
7b75d57
Compare
timoreimann
reviewed
Oct 7, 2019
cluster-autoscaler/cloudprovider/digitalocean/digitalocean_node_group.go
Outdated
Show resolved
Hide resolved
cluster-autoscaler/cloudprovider/digitalocean/digitalocean_cloud_provider.go
Outdated
Show resolved
Hide resolved
ecc52d5 to
4d6752f
Compare
andrewsykim
reviewed
Oct 21, 2019
cluster-autoscaler/cloudprovider/digitalocean/digitalocean_node_group_test.go
Outdated
Show resolved
Hide resolved
4d6752f to
37aa3f8
Compare
37aa3f8 to
7e69503
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
cluster-autoscalerusesnode.Spec.ProviderIDto determine which nodes are unregistered, so that they can be eventually deleted in an attempt to replace by registered instances. Thenode.Idthat we assign in cluster-autoscaler is the DOKS node UUID, so the nodes always look unregistered to the autoscaler, because they're using different IDs. This results in nodes flapping in and out of not ready as they're deleted via k8s by the cluster-autoscaler.Solution
Derive the cluster-autoscaler
node.Idfrom the node droplet ID and in the providerID form that it expects (i.e.digitalocean://12345678), instead of the DOKS node UUID.This also upgrades the vendored
godopackage.cc @timoreimann @andrewsykim