Skip to content

Commit

Permalink
Merge pull request #7743 from k8s-infra-cherrypick-robot/cherry-pick-…
Browse files Browse the repository at this point in the history
…7736-to-cluster-autoscaler-release-1.29

[cluster-autoscaler-release-1.29] chore: remove unnecessary logs on fast delete and add a relevant note
  • Loading branch information
k8s-ci-robot authored Jan 22, 2025
2 parents 4822ae2 + cf322e1 commit 6a0517c
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -231,15 +231,15 @@ func (scaleSet *ScaleSet) instanceStatusFromVM(vm *compute.VirtualMachineScaleSe
// ProvisioningState represents the most recent provisioning state, therefore only report
// InstanceCreating errors when the power state indicates the instance has not yet started running
if !isRunningVmPowerState(powerState) {
klog.V(4).Infof("VM %s reports failed provisioning state with non-running power state: %s", *vm.ID, powerState)
// This fast deletion relies on the fact that InstanceCreating + ErrorInfo will subsequently trigger a deletion.
// Could be revisited to rely on something more stable/explicit.
status.State = cloudprovider.InstanceCreating
status.ErrorInfo = &cloudprovider.InstanceErrorInfo{
ErrorClass: cloudprovider.OutOfResourcesErrorClass,
ErrorCode: "provisioning-state-failed",
ErrorMessage: "Azure failed to provision a node for this node group",
}
} else {
klog.V(5).Infof("VM %s reports a failed provisioning state but is running (%s)", *vm.ID, powerState)
status.State = cloudprovider.InstanceRunning
}
}
Expand Down

0 comments on commit 6a0517c

Please sign in to comment.