Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Lint Fixes in Codebase #779

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Additional Lint Fixes in Codebase #779

merged 3 commits into from
Mar 3, 2022

Conversation

DiptoChakrabarty
Copy link
Member

This is continuation of Issue #566

More lint fixes have been done and some spelling mistakes have been fixed.

@k8s-ci-robot
Copy link
Contributor

Hi @DiptoChakrabarty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2022
@marquiz
Copy link
Contributor

marquiz commented Feb 24, 2022

Thanks @DiptoChakrabarty for this PR! Will take a closer look later

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2022
marquiz
marquiz reviewed Feb 24, 2022
View reviewed changes
pkg/apihelper/k8shelpers.go Outdated Show resolved Hide resolved
pkg/apihelper/k8shelpers.go Outdated Show resolved Hide resolved
pkg/apihelper/k8shelpers.go Outdated Show resolved Hide resolved
pkg/nfd-client/base.go Outdated Show resolved Hide resolved
pkg/nfd-client/topology-updater/nfd-topology-updater.go Outdated Show resolved Hide resolved
source/fake/fake.go Outdated Show resolved Hide resolved
source/pci/pci.go Outdated Show resolved Hide resolved
source/pci/pci.go Outdated Show resolved Hide resolved
source/memory/memory.go Outdated Show resolved Hide resolved
source/memory/memory.go Outdated Show resolved Hide resolved
marquiz
marquiz approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DiptoChakrabarty, I think we can merge this

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2022
@marquiz
Copy link
Contributor

marquiz commented Mar 1, 2022

/assign @adrianchiris

ArangoGutierrez
ArangoGutierrez approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, DiptoChakrabarty, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 19a5778 into kubernetes-sigs:master Mar 3, 2022
@marquiz marquiz mentioned this pull request Mar 17, 2022
Closed
22 tasks
@DiptoChakrabarty DiptoChakrabarty mentioned this pull request Mar 23, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@marquiz marquiz marquiz approved these changes

@adrianchiris adrianchiris Awaiting requested review from adrianchiris

@kad kad Awaiting requested review from kad

Assignees

@ArangoGutierrez ArangoGutierrez

@adrianchiris adrianchiris

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DiptoChakrabarty @k8s-ci-robot @marquiz @ArangoGutierrez @adrianchiris