Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the incorrect references #769

Merged
merged 4 commits into from
Mar 15, 2022
Merged

Fixed the incorrect references #769

merged 4 commits into from
Mar 15, 2022

Conversation

vaibhav2107
Copy link
Contributor

The PR fixes some references that present in the customization guide in Advanced Section

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @vaibhav2107. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 3, 2022
@vaibhav2107
Copy link
Contributor Author

Fixes: #768

@vaibhav2107
Copy link
Contributor Author

Hi @ArangoGutierrez , @zvonkok
Could you please have a look.

ArangoGutierrez
ArangoGutierrez reviewed Feb 8, 2022
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR lgtm
/cc @marquiz
/lgtm

@k8s-ci-robot k8s-ci-robot requested a review from marquiz February 8, 2022 14:43
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@ArangoGutierrez
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2022
@ArangoGutierrez
Copy link
Contributor

@vaibhav2107: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-node-feature-discovery-verify-docs afd5bc4 link true /test pull-node-feature-discovery-verify-docs
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

@vaibhav2107 please fix

marquiz
marquiz reviewed Feb 8, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaibhav2107, looks good. You just need to fix the line length, i.e. wrap the lines you modified to correct lenght in order to make mdlint happy

@vaibhav2107
Copy link
Contributor Author

Thanks @marquiz , @ArangoGutierrez for reviewing,
will fix it.

@ArangoGutierrez
Copy link
Contributor

Any updates here @vaibhav2107 ?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2022
@vaibhav2107
Copy link
Contributor Author

PTAL @ArangoGutierrez , @marquiz

@marquiz
Copy link
Contributor

marquiz commented Feb 21, 2022

PTAL @ArangoGutierrez , @marquiz

Umm, the lines are not quite wrapped right and mdlint is unhappy
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_node-feature-discovery/769/pull-node-feature-discovery-verify-docs/1495674448898953216

Please fix these and also squash the PR into one commit

@marquiz
Copy link
Contributor

marquiz commented Mar 1, 2022

ping @vaibhav2107 please update the pr

@marquiz
Copy link
Contributor

marquiz commented Mar 7, 2022

/retest

marquiz
marquiz approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz, vaibhav2107

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@vaibhav2107
Copy link
Contributor Author

Ah, at last, cleared all tests,

@vaibhav2107
Copy link
Contributor Author

Thanks @marquiz for approving, could you help in squashing the commits as got some issue in my local

@marquiz
Copy link
Contributor

marquiz commented Mar 7, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 7, 2022
@ArangoGutierrez
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit b070684 into kubernetes-sigs:master Mar 15, 2022
@marquiz marquiz mentioned this pull request Mar 17, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez left review comments

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaibhav2107 @k8s-ci-robot @ArangoGutierrez @marquiz