be a bit more verbose on a required KUBECONFIG env var #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @marquiz |
marquiz
reviewed
Nov 24, 2020
Makefile
Outdated
| @@ -113,7 +113,8 @@ test: | |||
| $(GO_CMD) test ./cmd/... ./pkg/... | |||
|
|
|||
| e2e-test: | |||
| $(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) -kubeconfig=$(KUBECONFIG) -nfd.e2e-config=$(E2E_TEST_CONFIG) -ginkgo.focus="\[NFD\]" | |||
| @if [ -z ${KUBECONFIG} ]; then echo "[ERR] KUBECONFIG missing, must be defined" && exit 1; fi | |||
There was a problem hiding this comment.
nit: use ; instead of && between echo and exit
88d0789 to
defb574
Compare
|
Also just noted, I got to do the 404 pun !!! PR not found LOL |
marquiz
reviewed
Nov 24, 2020
Makefile
Outdated
| @@ -113,7 +113,8 @@ test: | |||
| $(GO_CMD) test ./cmd/... ./pkg/... | |||
|
|
|||
| e2e-test: | |||
| $(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) -kubeconfig=$(KUBECONFIG) -nfd.e2e-config=$(E2E_TEST_CONFIG) -ginkgo.focus="\[NFD\]" | |||
| @if [ -z ${KUBECONFIG} ]; then echo "[ERR] KUBECONFIG missing, must be defined"; exit 1; fi | |||
| $(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) -kubeconfig=$(KUBECONFIG) -nfd.e2e-config=$(E2E_TEST_CONFIG) -ginkgo.focus="\[NFD\]"; \ | |||
There was a problem hiding this comment.
Ach, I forgot this from the previous review: you shouldn't need to change this line (this ; \ is unnecessary)
Otherwise looks good
5394f02 to
3b2b312
Compare
marquiz
requested changes
Nov 24, 2020
Makefile
Outdated
| @@ -113,7 +113,8 @@ test: | |||
| $(GO_CMD) test ./cmd/... ./pkg/... | |||
|
|
|||
| e2e-test: | |||
| $(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) -kubeconfig=$(KUBECONFIG) -nfd.e2e-config=$(E2E_TEST_CONFIG) -ginkgo.focus="\[NFD\]" | |||
| @if [ -z ${KUBECONFIG} ]; then echo "[ERR] KUBECONFIG missing, must be defined"; exit 1; fi | |||
There was a problem hiding this comment.
nit: double-space before exit
Makefile
Outdated
| @@ -113,7 +113,8 @@ test: | |||
| $(GO_CMD) test ./cmd/... ./pkg/... | |||
|
|
|||
| e2e-test: | |||
| $(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) -kubeconfig=$(KUBECONFIG) -nfd.e2e-config=$(E2E_TEST_CONFIG) -ginkgo.focus="\[NFD\]" | |||
| @if [ -z ${KUBECONFIG} ]; then echo "[ERR] KUBECONFIG missing, must be defined"; exit 1; fi | |||
| $(GO_CMD) test -v ./test/e2e/ -args -nfd.repo=$(IMAGE_REPO) -nfd.tag=$(IMAGE_TAG_NAME) -kubeconfig=$(KUBECONFIG) -nfd.e2e-config=$(E2E_TEST_CONFIG) -ginkgo.focus="\[NFD\]" | |||
There was a problem hiding this comment.
nit: remove trailing whitespace from the end of the line
|
3b2b312 to
76c1117
Compare
cb69c92 to
950675a
Compare
Done |
This Patch adds a check on make target e2e-test, to check if the KUBECONFIG env var is set before running the test suite. if not pressent return a valid error message. Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
950675a to
30e6446
Compare
marquiz
approved these changes
Nov 25, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throw an error message before running
e2e-testifKUBECONFIGis not definedSigned-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com