-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nfd-worker-conf ConfigMap to deployment templates #386
Add nfd-worker-conf ConfigMap to deployment templates #386
Conversation
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The operator does the same, an empty file, maybe we could, in the name of documentation, not do it via a virtual empty but a commented file (wish has the same effect) , and will help people
name: nfd-worker-conf | ||
namespace: node-feature-discovery | ||
data: | ||
nfd-worker.conf: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nfd-worker.conf: | | |
nfd-worker.conf: | | |
#uncomment to configure | |
#sources: | |
# pci: | |
# deviceClassWhitelist: | |
# - "0200" | |
# - "03" | |
# - "12" | |
# deviceLabelFields: | |
# - "class" | |
# - "vendor" | |
# - "device" | |
# - "subsystem_vendor" | |
# - "subsystem_device" |
name: nfd-worker-conf | ||
namespace: node-feature-discovery | ||
data: | ||
nfd-worker.conf: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nfd-worker.conf: | | |
nfd-worker.conf: | | |
#uncomment to configure | |
#sources: | |
# pci: | |
# deviceClassWhitelist: | |
# - "0200" | |
# - "03" | |
# - "12" | |
# deviceLabelFields: | |
# - "class" | |
# - "vendor" | |
# - "device" | |
# - "subsystem_vendor" | |
# - "subsystem_device" |
name: nfd-worker-conf | ||
namespace: node-feature-discovery | ||
data: | ||
nfd-worker.conf: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nfd-worker.conf: | | |
nfd-worker.conf: | | |
#uncomment to configure | |
#sources: | |
# pci: | |
# deviceClassWhitelist: | |
# - "0200" | |
# - "03" | |
# - "12" | |
# deviceLabelFields: | |
# - "class" | |
# - "vendor" | |
# - "device" | |
# - "subsystem_vendor" | |
# - "subsystem_device" |
I was thinking about something like the changes you suggested, but, decided otherwise. I wanted to have all the available options visible in the configmap, this now happens when But, on a second thought it would be really nice to have the example also in the templates. I'll sketch up something. BBL |
Add TLS placeholders.
Add a virtually empty ConfigMap that is mounted inside the workers. Makes it easier to start customizing the worker deployment e.g. with just: $ kubectl -n ${NFD_NS} edit configmap nfd-worker-conf Create a new 'templates' make target for inserting the content of nfd-worker.conf.example into the configmap spec of the templates. Thus, 'make templates' should be run whenever the example config is update. Update the verify.sh prow script to check that the templates are up to date. This patch also streamlines the documentation about configuration management, reflecting the changes.
f911316
to
979d3b8
Compare
Changed the patch so that the configmaps in templates have same data than |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your example is waaaay better than mine
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a virtually empty ConfigMap that is mounted inside the workers.
Makes it easier to start customizing the worker deployment e.g. with just:
$ kubectl -n ${NFD_NS} edit configmap nfd-worker-conf
Create a new 'templates' make target for inserting the content of
nfd-worker.conf.example into the configmap spec of the templates. Thus,
'make templates' should be run whenever the example config is update.
Update the verify.sh prow script to check that the templates are up to
date.
This patch also streamlines the documentation about configuration
management, reflecting the changes.