nfd-master: implement --prune flag #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ArangoGutierrez: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jjacobelli
suggested changes
Aug 21, 2020
|
Otherwise LGTM |
A new sub-command like flag for cleaning up a cluster. When --prune is specified nfd-master removes all NFD related labels, annotations and extended resources from all nodes of the cluster and exits. This should help undeployment of NFD and be useful for development.
Useful with --prune and for development purposes.
|
Rebased and addressed the comment from @Ethyling |
The bare minimum doc update.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new sub-command like flag for cleaning up a cluster. When
--pruneisspecified nfd-master removes all NFD related labels, annotations and
extended resources from all nodes of the cluster and exits.
Also, add new
--kubeconfigflag. Useful with--pruneand for development purposes.