Update go version in Dockerfile

[ArangoGutierrez]

Update go version in Docker build image to v1.13.5

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

[k8s-ci-robot]

Welcome @ArangoGutierrez!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[marquiz]

Thank you for the patch. I think we should keep travis.yml in sync with the Dockerfile so that would need to be updated, too.

[ArangoGutierrez]

sure, will patch the .travis.yml file as well

[ArangoGutierrez]

@marquiz you think we should do

language: go
go:
  - "1.13"
  - "1.13.x"

or just 1.13?

[marquiz]

I think one version should be enough. We could stay in full sync with the dockerfile and use 1.13.5(?)

[ArangoGutierrez]

done

[marquiz]

Hmm, end-to-end tests fail with go 1.13 🤔

Looks like the kubernetes version we're using as a dep (the e2e test framework from it) is incompatible with go 1.13. We should update the dep(s) to k8s v1.17 and try with that.

[marquiz]

Updating the deps wasn't quite that simple. I just submitted #282 to do that. We should merge that first and then try your PR on top of it.

[ArangoGutierrez]

thanks for #282 , rebased and updated

[marquiz]

You prolly should re-do the last patch (i.e. update go.mod). go mod tidy hasn't worked as expected as it hasn't removed anything, just added quite a bit of stuff to go.sum. Also the commit message should be corrected accordingly

[marquiz]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[marquiz]

/lgtm