Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up SCC OpenShift deps #89

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Clean up SCC OpenShift deps #89

merged 1 commit into from
Sep 30, 2021

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 30, 2021
@ArangoGutierrez ArangoGutierrez mentioned this pull request Sep 30, 2021
Merged
marquiz
marquiz reviewed Sep 30, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool @ArangoGutierrez, good cleanup.

Should we remove security.openshift.io from config/rbac/ roles, too?

@marquiz
Copy link
Contributor

marquiz commented Sep 30, 2021

Oh, and should the commit message subject be deps instead of depts?

@ArangoGutierrez
Clean up SCC OpenShift deps
53a9f01 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez ArangoGutierrez changed the title Clean up SCC OpenShift depts Clean up SCC OpenShift deps Sep 30, 2021
marquiz
marquiz approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like reducing LOC 😄
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7e315bd into kubernetes-sigs:master Sep 30, 2021
@ArangoGutierrez ArangoGutierrez added the hacktoberfest-accepted hacktoberfest participating issue label Oct 5, 2021
@marquiz marquiz mentioned this pull request Oct 26, 2021
Closed
13 tasks
@ArangoGutierrez ArangoGutierrez deleted the devel/clean_openshift branch March 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. hacktoberfest-accepted hacktoberfest participating issue lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @marquiz @k8s-ci-robot