Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use apimachinery error library to check for missing nfd instance #80

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Use apimachinery error library to check for missing nfd instance #80

merged 1 commit into from
Aug 11, 2021

Conversation

courtneypacheco
Copy link
Contributor

The existing error checking library in the cri-api package was used to check for the case where the NFD instance is deleted. However, this error checking library is used for GRPC specific errors, not for errors related to the metav1 package. The metav1 package is used by various k8s resources (e.g., DaemonSet, Service, etc.), and thus, we should be checking for metav1 problems, not GRPC problems.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @courtneypacheco. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from marquiz August 9, 2021 22:22
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2021
@ArangoGutierrez
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2021
@marquiz
Copy link
Contributor

marquiz commented Aug 10, 2021

Thanks @courtneypacheco for the patch!

Need to gofmt:
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_node-feature-discovery-operator/80/pull-node-feature-discovery-operator-verify/1424869545398505472

Otherwise lgtm

@ArangoGutierrez
Copy link
Contributor

Thanks for the review @marquiz
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@marquiz
Copy link
Contributor

marquiz commented Aug 10, 2021

nit: could you squash the commits into one? gofmt should be part of the first (single) patch.

@courtneypacheco
Use apimachinery error library to check for missing nfd instance
5a17c59 
The existing error checking library in the cri-api package was used
to check for the case where the NFD instance is deleted. However,
this error checking library is used for GRPC specific errors, not
for errors related to the 'metav1' package. The 'metav1' package is
used by various k8s resources (e.g., DaemonSet, Service, etc.),
and thus, we should be checking for 'metav1' problems, not GRPC
problems.
@courtneypacheco courtneypacheco force-pushed the bug_controller_mgr_error_check branch from a2981c2 to 5a17c59 Compare August 10, 2021 19:17
@courtneypacheco
Copy link
Contributor Author

Thanks, @marquiz! I'm ready for review again whenever you have the time!

marquiz
marquiz approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @courtneypacheco! Looks good. Plus I really like your commit messages 😊

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, courtneypacheco, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3b48907 into kubernetes-sigs:master Aug 11, 2021
@courtneypacheco courtneypacheco deleted the bug_controller_mgr_error_check branch August 24, 2021 15:02
@marquiz marquiz mentioned this pull request Oct 26, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@courtneypacheco @k8s-ci-robot @ArangoGutierrez @marquiz