Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BASE_IMAGE_FULL build arg #78

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Add BASE_IMAGE_FULL build arg #78

merged 2 commits into from
Aug 11, 2021

Conversation

ArangoGutierrez
Copy link
Contributor

This patch :

  • Bumps base go image to 1.16.6
  • updates second stage image to be consistent with NFD via build args

@ArangoGutierrez
Update go image to 1.16.6
6cfe40d 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Use BASE_IMAGE_FULL build arg
dbb6b07 
use a more upstream base image for second stage `debian:buster-slim`
leaving it open for change via build arg and Makefile var
BASE_IMAGE_FULL

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2021
@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok August 4, 2021 21:24
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2021
@ArangoGutierrez
Copy link
Contributor Author

/assign marquiz

@marquiz
Copy link
Contributor

marquiz commented Aug 10, 2021

Looks basically good. Just pondering the naming of the variable, are you planning to have a minimal image similar to NFD (operand)? If not, we could drop the _FULL suffix from it.

@ArangoGutierrez
Copy link
Contributor Author

Looks basically good. Just pondering the naming of the variable, are you planning to have a minimal image similar to NFD (operand)? If not, we could drop the _FULL suffix from it.

Ready for second pass :)

@ArangoGutierrez
Copy link
Contributor Author

/joke

@ArangoGutierrez
Copy link
Contributor Author

/test all

@ArangoGutierrez
Copy link
Contributor Author

/joke

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: The first time I got a universal remote control I thought to myself, "This changes everything"

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@ArangoGutierrez: How many hipsters does it take to change a lightbulb? Oh, it's a really obscure number. You've probably never heard of it.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ArangoGutierrez
Copy link
Contributor Author

Looks basically good. Just pondering the naming of the variable, are you planning to have a minimal image similar to NFD (operand)? If not, we could drop the _FULL suffix from it.

ArangoGutierrez@642bf6a

@marquiz
Copy link
Contributor

marquiz commented Aug 10, 2021

nit: the title of this PR is misleading. I'd change it to something like Add BASE_IMAGE_FULL build arg

@ArangoGutierrez
Copy link
Contributor Author

/retitle Add BASE_IMAGE_FULL build arg

@k8s-ci-robot k8s-ci-robot changed the title Update Dockerfile to use build args Add BASE_IMAGE_FULL build arg Aug 10, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2021
marquiz
marquiz reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd better add the minimal image in a separate PR.

Need to add CI support (build-image and push-image) plus preferably mention that in the documentation, too.

Talking about CI, should we have an images Makefile target building both images and use that in scripts/test-infra/build-image.sh 🤔

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
@ArangoGutierrez
Copy link
Contributor Author

I think we'd better add the minimal image in a separate PR.

Need to add CI support (build-image and push-image) plus preferably mention that in the documentation, too.

Talking about CI, should we have an images Makefile target building both images and use that in scripts/test-infra/build-image.sh thinking

OK, removed the commit, will turn that one into a PR, + documentation + CI (in a single PR)

marquiz
marquiz approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, now

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c94eed9 into kubernetes-sigs:master Aug 11, 2021
@ArangoGutierrez ArangoGutierrez deleted the devel/go-1.16.6 branch August 11, 2021 23:35
@ArangoGutierrez
Copy link
Contributor Author

Follow up PR #82

@marquiz marquiz mentioned this pull request Oct 26, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @marquiz @k8s-ci-robot