Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for extra-label-ns, label-whitelist, resource-labels #77

Merged
merged 1 commit into from
Aug 26, 2021
Merged

add support for extra-label-ns, label-whitelist, resource-labels #77

merged 1 commit into from
Aug 26, 2021

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Jul 20, 2021 •
edited
Loading

NFD validates label ns by extra-label-ns, label-whitelist, resource-labels args, but the operator has not yet supported it.

this PR added those under spec:

  • extraLabelN as a list of strings
  • labelWhiteList as a string of regexp
  • resourceLabels as a list of strings

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @zwpaper. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok July 20, 2021 09:14
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2021
@zwpaper zwpaper changed the title add support for extra-label-ns add support for extra-label-ns, label-whitelist, resource-labels Jul 21, 2021
@zwpaper
Copy link
Member Author

zwpaper commented Jul 21, 2021 •
edited
Loading

looks like there is a rbac problem for the master adding extend resource, working on it

@zwpaper
Copy link
Member Author

zwpaper commented Jul 26, 2021

Hi @ArangoGutierrez and @marquiz, I have finished this PR, could you please help to review it, let me know if there is anything I should do next, thanks!

ArangoGutierrez
ArangoGutierrez requested changes Aug 4, 2021
View reviewed changes
build/assets/master/0200_clusterrole.yaml Outdated
@@ -8,8 +8,8 @@ rules:
resources:
- pods
- nodes
- nodes/status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of scope from the PR description, could you separate this commit into a new PR? thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ArangoGutierrez , thanks for the review, the rbac commit is deleted, and new PR for it was raised #79, please also have a look at it, thanks!

@zwpaper zwpaper mentioned this pull request Aug 5, 2021
Merged
@ArangoGutierrez
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2021
ArangoGutierrez
ArangoGutierrez requested changes Aug 12, 2021
View reviewed changes
api/v1/nodefeaturediscovery_types.go Show resolved Hide resolved
api/v1/nodefeaturediscovery_types.go Show resolved Hide resolved
api/v1/nodefeaturediscovery_types.go Show resolved Hide resolved
config/samples/nfd.kubernetes.io_v1_nodefeaturediscovery.yaml Outdated
Comment on lines 8 to 10
labelWhiteList: ""
extraLabelNs: null
resourceLabels: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If nullable, there's no need to have them on the sample

@zwpaper
Copy link
Member Author

zwpaper commented Aug 13, 2021

hi @ArangoGutierrez , I have added the nullable option and comment out the newly added args in the example, pls have a look again, thanks.

marquiz
marquiz requested changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍

Just one wish: could you squash this into one commit? Plus one nit:
The first word in the commit message subject should be capitalized unless it starts with a lowercase symbol or other identifier

@zwpaper
Add support for extraLabelNs, resourceLabels, labelWhiteList
85ddce7 
Signed-off-by: Wei Zhang <kweizh@gmail.com>
@zwpaper
Copy link
Member Author

zwpaper commented Aug 13, 2021

thanks for the guideline @marquiz , updated

@zwpaper zwpaper requested a review from marquiz August 13, 2021 16:45
@zwpaper
Copy link
Member Author

zwpaper commented Aug 20, 2021

hi @ArangoGutierrez, is there anything I need to do to make this PR happen?

@ArangoGutierrez
Copy link
Contributor

hi @ArangoGutierrez, is there anything I need to do to make this PR happen?

Hey sorry been busy in my personal life, will review and test this one this week, thanks for your patience

marquiz
marquiz reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Let @ArangoGutierrez make the call

@marquiz
Copy link
Contributor

marquiz commented Aug 24, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2021
ArangoGutierrez
ArangoGutierrez approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, zwpaper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7f2ca84 into kubernetes-sigs:master Aug 26, 2021
@marquiz marquiz mentioned this pull request Oct 26, 2021
Closed
13 tasks
@zwpaper zwpaper mentioned this pull request Mar 3, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

@marquiz marquiz Awaiting requested review from marquiz

Assignees

@marquiz marquiz

@ArangoGutierrez ArangoGutierrez

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zwpaper @k8s-ci-robot @ArangoGutierrez @marquiz