Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport documentation pages #75

Merged

Conversation

ArangoGutierrez
Copy link
Contributor

BackPort Doc pages to v0.2.0

* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* docs: show full version number in sidebar

Change the sidebar customization so that the full version (e.g. v0.2.0)
is displayed, instead of the truncated "releae branch version" (e.g.
v0.2) in the top left corner of the page. The items in the version menu
are unchanged and will still show the shorter form.

Cherry picked from node-feature-discovery repo commit
4d19e1ab85b6cf4c6a2f6e556bf04654e4fb238e.

* beat yamllinter

remove the whitespace (around the template variable) to prevent needing to split the reference into multiple lines

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>

* Create a minimum documentation page

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* parametize docs dependant of version

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* use production image

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* use operand_version for doc config

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* use container_image as example IMAGE_TAG

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* use release to force a better git clone

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* add small documentation to variable on config site

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* last fixes or I will unfriend Markus

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok June 2, 2021 19:46
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2021
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @ArangoGutierrez!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8f747e0 into kubernetes-sigs:release-0.2 Jun 3, 2021
@ArangoGutierrez ArangoGutierrez mentioned this pull request Oct 26, 2021
13 tasks
@ArangoGutierrez ArangoGutierrez deleted the bp/docs_v2 branch March 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants