Sync Makefile with NFD Operand #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marquiz
reviewed
Apr 12, 2021
Makefile
Outdated
| @@ -61,15 +63,16 @@ IMAGE_EXTRA_TAG_NAMES ?= | |||
| IMAGE_REPO := $(IMAGE_REGISTRY)/$(IMAGE_NAME) | |||
| IMAGE_TAG := $(IMAGE_REPO):$(IMAGE_TAG_NAME) | |||
| IMAGE_EXTRA_TAGS := $(foreach tag,$(IMAGE_EXTRA_TAG_NAMES),$(IMAGE_REPO):$(tag)) | |||
| CONTAINER_RUN_CMD ?= docker run -u "`id -u`:`id -g`" | |||
There was a problem hiding this comment.
This should be specified before SITE_BUILD_CMD
This patch aligns the Makefile to honor NFD operand style making both Makefiles feel they belong to the same project Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
571946e to
28e165a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aligns the Makefile to honor NFD operand style
making both Makefiles feel they belong to the same project
Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com