master:worker nodes enablement for nfd-worker #37
Conversation
|
@rmkraus FYI |
|
Discussion started in a downstream distribution of NFD: openshift/cluster-nfd-operator#109 |
|
/assign @marquiz |
There was a problem hiding this comment.
Thanks @ArangoGutierrez ! The change ooks good.
My only gripe is about the commit message which is very minimal and confusing. E.g. in the description of this PR there is somewhat good background information which could be used (almost as is) in the commit message
02a9da3 to
e4aad50
Compare
After kubernetes-sigs#31 three node cluster, where all nodes will have the master and worker(or node for vanilla clusters) labels are just getting the nfd-master daemonset deployed. Since they have the master label, the NFD workers will not be scheduled. Discussion started in a downstream distribution of NFD: openshift/cluster-nfd-operator#109 This Patch fix that, by adding support for master:worker type of nodes, modifying the nodeAffinity rules on the nfd-worker daemonSet to allow any node with the "node" label (independent if it is a master also) to get scheduled Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
e4aad50 to
442c7d1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez, marquiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After #31 three node cluster, where all nodes will have the master and worker(or node for vanilla clusters) labels are just getting the nfd-master daemonset deployed. Since they have the master label, the NFD workers will not be scheduled.
This Patch fix that adding support for master:worker type of nodes, being used in edge deployments
Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com