Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm docs #186

Merged
merged 5 commits into from
Mar 14, 2023
Merged

Helm docs #186

merged 5 commits into from
Mar 14, 2023

Conversation

ArangoGutierrez
Copy link
Contributor

No description provided.

@ArangoGutierrez
HELM values nfd -> controller
eef1951 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez
DOCS: Add deployment/image-variants
96b3f44 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez
DOCS: Add deployment/helm
2bdb963 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez ArangoGutierrez mentioned this pull request Mar 13, 2023
Closed
5 tasks
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok March 13, 2023 13:58
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2023
@ArangoGutierrez
Copy link
Contributor Author

/retest

1 similar comment
@marquiz
Copy link
Contributor

marquiz commented Mar 13, 2023

/retest

marquiz
marquiz reviewed Mar 14, 2023
View reviewed changes
docs/deployment/image-variants.md Outdated Show resolved Hide resolved
docs/deployment/image-variants.md Outdated Show resolved Hide resolved
docs/deployment/image-variants.md Outdated Show resolved Hide resolved
docs/deployment/image-variants.md Show resolved Hide resolved
docs/deployment/uninstallation.md Outdated Show resolved Hide resolved
docs/deployment/uninstallation.md Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Mar 14, 2023

You also need to add docs/deployment/index.md I think

@ArangoGutierrez ArangoGutierrez mentioned this pull request Mar 14, 2023
Closed
@ArangoGutierrez ArangoGutierrez requested a review from marquiz March 14, 2023 10:44
@ArangoGutierrez ArangoGutierrez force-pushed the helm_docs branch 3 times, most recently from 5d6adf9 to d297273 Compare March 14, 2023 11:03
@marquiz
Copy link
Contributor

marquiz commented Mar 14, 2023 •
edited
Loading

The docs don't still look quite right 🧐 Have you tried make site-serve to see the outcome?

EDIT: the deployment pages are not shown

@ArangoGutierrez ArangoGutierrez force-pushed the helm_docs branch 2 times, most recently from 4189fb3 to 99e6332 Compare March 14, 2023 11:21
marquiz
marquiz reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to drop the "image variants" section from quick-start.md. Also, this widens the scope of this PR so it could be a separate one, I'd suggest to change the quick-start instructions to be Helm based. Sooo much easier to deploy than with git clone and all that stuff. And, if we do this, I'd suggest to move the git-clone-based deployment instructions under deployment/manual.md (or smth), and move most of the stuff in uninstallation.md there, too

docs/deployment/index.md Outdated Show resolved Hide resolved
docs/deployment/index.md Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez requested a review from marquiz March 14, 2023 11:46
marquiz
marquiz reviewed Mar 14, 2023
View reviewed changes
docs/deployment/image-variants.md Outdated Show resolved Hide resolved
docs/deployment/image-variants.md Outdated Show resolved Hide resolved
docs/get-started/index.md Outdated Show resolved Hide resolved
docs/deployment/index.md Show resolved Hide resolved
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/contributing/index.md Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the helm_docs branch 3 times, most recently from 45864d1 to 1ffdbad Compare March 14, 2023 13:26
marquiz
marquiz reviewed Mar 14, 2023
View reviewed changes
docs/deployment/helm.md Outdated Show resolved Hide resolved
docs/deployment/image-variants.md Outdated Show resolved Hide resolved
docs/deployment/manual.md Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez requested a review from marquiz March 14, 2023 13:58
marquiz
marquiz reviewed Mar 14, 2023
View reviewed changes
docs/deployment/cleanup.md Outdated Show resolved Hide resolved
docs/deployment/cleanup.md Outdated Show resolved Hide resolved
docs/deployment/cleanup.md Show resolved Hide resolved
docs/deployment/cleanup.md Outdated Show resolved Hide resolved
docs/get-started/index.md Outdated Show resolved Hide resolved
@marquiz
Copy link
Contributor

marquiz commented Mar 14, 2023

Plz respond to #186 (comment)

@marquiz marquiz mentioned this pull request Mar 14, 2023
Closed
16 tasks
@ArangoGutierrez
DOCS: Add deployment/uninstallation
a804c16 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez
Enhance docs/advanced
9d5c81a 
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
@ArangoGutierrez ArangoGutierrez requested a review from marquiz March 14, 2023 19:23
@ArangoGutierrez ArangoGutierrez added this to the v0.6.0 milestone Mar 14, 2023
marquiz
marquiz approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. Didn't spot anything obvious -> let's fix later if something comes up
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3e940ba into kubernetes-sigs:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @marquiz @k8s-ci-robot