Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap default image to Minimal #157

Merged
merged 1 commit into from
May 19, 2022
Merged

Swap default image to Minimal #157

merged 1 commit into from
May 19, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Fixes #146

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2022
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok May 17, 2022 16:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2022
@ArangoGutierrez ArangoGutierrez changed the title Issues/146 Swap default image to Minimal May 17, 2022
@ArangoGutierrez ArangoGutierrez added this to the v0.5.0 milestone May 17, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request May 17, 2022
Closed
31 tasks
marquiz
marquiz reviewed May 18, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez. Does documentation need any updating?

@ArangoGutierrez ArangoGutierrez requested a review from marquiz May 18, 2022 16:07
@ArangoGutierrez ArangoGutierrez force-pushed the issues/146 branch 2 times, most recently from 73c528c to b070f00 Compare May 18, 2022 16:44
@ArangoGutierrez
Swap default image to Minimal
227efb0 
Point master manifest to staging registry
Document minimal image tag as default
Use master-minimal on CSV example

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez ArangoGutierrez requested a review from marquiz May 19, 2022 13:17
marquiz
marquiz approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit de24a0e into kubernetes-sigs:master May 19, 2022
@ArangoGutierrez ArangoGutierrez deleted the issues/146 branch March 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

Swap default image to Minimal
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz