Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry/0.4.2 #145

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Cherry/0.4.2 #145

merged 3 commits into from
Apr 26, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

@ArangoGutierrez ArangoGutierrez commented Apr 19, 2022 •
edited
Loading

@ArangoGutierrez
Run nfd-master as Deployment
e9210f7 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Update kubebuilder rbac
27222e4 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2022
@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok April 19, 2022 17:05
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 19, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request Apr 19, 2022
Closed
14 tasks
@ArangoGutierrez
Copy link
Contributor Author

/test pull-node-feature-discovery-operator-verify

@ArangoGutierrez
Copy link
Contributor Author 

[eduardo@fedora-workstation node-feature-discovery-operator]$ make verify-gofmt 
gofmt OK
[eduardo@fedora-workstation node-feature-discovery-operator]$ ./scripts/verify-gofmt.sh 
gofmt OK
[eduardo@fedora-workstation node-feature-discovery-operator]$ make verify
gofmt OK
golangci-lint run --timeout 5m0s

/test pull-node-feature-discovery-operator-verify

marquiz
marquiz approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 90a8681 into kubernetes-sigs:release-0.4 Apr 26, 2022
@ArangoGutierrez ArangoGutierrez deleted the cherry/0.4.2 branch March 13, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz