Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to 1.18 #135

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Bump Go to 1.18 #135

merged 1 commit into from
Apr 13, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@ArangoGutierrez
Copy link
Contributor Author

ArangoGutierrez commented Mar 16, 2022 •
edited
Loading

Hold on after -> kubernetes/test-infra#25652

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2022
@k8s-ci-robot k8s-ci-robot requested review from marquiz and zvonkok March 16, 2022 15:03
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2022
@ArangoGutierrez
Copy link
Contributor Author

/hold cancel
/assign @marquiz

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
@ArangoGutierrez
Copy link
Contributor Author

Rebased and ready for review

@ArangoGutierrez
Copy link
Contributor Author

Depends on kubernetes/test-infra#25652

@qbarrand qbarrand mentioned this pull request Apr 11, 2022
Closed
marquiz
marquiz reviewed Apr 12, 2022
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@ArangoGutierrez ArangoGutierrez force-pushed the devel/go_118 branch 2 times, most recently from 7f57f70 to 1d1f805 Compare April 12, 2022 15:11
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2022
@ArangoGutierrez ArangoGutierrez requested a review from marquiz April 12, 2022 15:11
@ArangoGutierrez @marquiz
Bump Go to 1.18
6485911 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
marquiz
marquiz approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
/lgtm

Let's wait for kubernetes/test-infra#25652 to get merged
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ArangoGutierrez
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2022
@marquiz
Copy link
Contributor

marquiz commented Apr 12, 2022

/test all

@ArangoGutierrez
Copy link
Contributor Author

I think we need to also update go.mod to fix the tests

@marquiz
Copy link
Contributor

marquiz commented Apr 13, 2022

I think we need to also update go.mod to fix the tests

#139 should be enough

@marquiz
Copy link
Contributor

marquiz commented Apr 13, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit f96c117 into kubernetes-sigs:master Apr 13, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request May 17, 2022
Closed
31 tasks
@ArangoGutierrez ArangoGutierrez deleted the devel/go_118 branch March 13, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

@zvonkok zvonkok Awaiting requested review from zvonkok

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @k8s-ci-robot @marquiz