Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable status checks and finalizers for TopologyUpdater #117

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Enable status checks and finalizers for TopologyUpdater #117

merged 3 commits into from
Feb 11, 2022

Conversation

ArangoGutierrez
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2022
@ArangoGutierrez ArangoGutierrez removed the request for review from zvonkok February 9, 2022 17:01
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 9, 2022
@ArangoGutierrez
Copy link
Contributor Author

/assign @marquiz

@ArangoGutierrez ArangoGutierrez mentioned this pull request Feb 9, 2022
Closed
@ArangoGutierrez ArangoGutierrez added this to the v0.4.0 milestone Feb 9, 2022
@ArangoGutierrez ArangoGutierrez mentioned this pull request Feb 9, 2022
Closed
14 tasks
marquiz
marquiz reviewed Feb 9, 2022
View reviewed changes
controllers/nodefeaturediscovery_status.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_status.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 11, 2022 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 11, 2022
ArangoGutierrez and others added 2 commits February 11, 2022 09:34
@ArangoGutierrez @marquiz
Add status checks for TopologyUpdater
e3bbd9a 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
@ArangoGutierrez
Enable finalizer check for the CRD
685deb4 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 11, 2022
marquiz
marquiz reviewed Feb 11, 2022
View reviewed changes
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_finalizers.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
controllers/nodefeaturediscovery_resources.go Outdated Show resolved Hide resolved
@ArangoGutierrez @marquiz
Apply suggestions from code review
74eb00e 
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
@ArangoGutierrez
Copy link
Contributor Author

/test-required

@ArangoGutierrez
Copy link
Contributor Author

/retest-required

@marquiz
Copy link
Contributor

marquiz commented Feb 11, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 11, 2022
marquiz
marquiz approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@marquiz marquiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to get this functionality covered 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ArangoGutierrez,marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b4552ce into kubernetes-sigs:master Feb 11, 2022
@ArangoGutierrez ArangoGutierrez deleted the devel/v0.4 branch March 13, 2023 10:32
ArangoGutierrez added a commit to ArangoGutierrez/node-feature-discovery-operator that referenced this pull request Mar 19, 2023
@ArangoGutierrez @marquiz
Enable status checks and finalizers for TopologyUpdater (kubernetes-s…
33ce9fe 
…igs#117)

* Add status checks for TopologyUpdater

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>

* Enable finalizer check for the CRD

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>

* Apply suggestions from code review

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>

Co-authored-by: Markus Lehtonen <markus.lehtonen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marquiz marquiz marquiz approved these changes

Assignees

@marquiz marquiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @marquiz @k8s-ci-robot