extraLabelNs field has a bug

[wangxiaoyang-dev]

What happened:
If i enable extraLabelNs field in NodeFeatureDiscovery CR, like this:
extraLabelNs:
- nvidia.com
nfd-master pod will log:
E0427 03:19:50.717545 7 nfd-master.go:367] Namespace "nvidia.com" is not allowed. Ignoring label "nvidia.com/gpu.product"
nfd-master's start parameter like this:
args:

• '--extra-label-ns="nvidia.com"'

but nfd-master's correct start parameter should be this:
args:

• '--extra-label-ns=nvidia.com'

What you expected to happen:
If i enable extraLabelNs field in NodeFeatureDiscovery CR, like this:
extraLabelNs:
- nvidia.com

nfd-master's start parameter should be this:
args:

• '--extra-label-ns=nvidia.com'

nfd-master pod does not log:
E0427 03:19:50.717545 7 nfd-master.go:367] Namespace "nvidia.com" is not allowed. Ignoring label "nvidia.com/gpu.product"

How to reproduce it (as minimally and precisely as possible):
Use the newest version of node-feature-discovery-operator can reproduce this bug

Anything else we need to know?:
Here source has a bug:
https://github.com/kubernetes-sigs/node-feature-discovery-operator/blob/master/controllers/nodefeaturediscovery_controls.go#:~:text=args%20%3D%20append(args%2C%20fmt.Sprintf(%22%2D%2Dextra%2Dlabel%2Dns%3D%25q%22%2C%20strings.Join(n.ins.Spec.ExtraLabelNs%2C%20%22%2C%22)))
"--extra-label-ns=%q" should be changed to "--extra-label-ns=%s"
"--resource-labels=%q" should be changed to "--resource-labels=%s"
"--label-whitelist=%q" should be changed to "--label-whitelist=%s"

[marquiz]

Thanks for reporting this @wangxiaoyang-dev! Ping @ArangoGutierrez. Looks like we need v0.4.3... 😺

[ArangoGutierrez]

#151

[ArangoGutierrez]

/close

[k8s-ci-robot]

@ArangoGutierrez: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.