Preserve name of the PV directory name during archiving

[petermicuch]

This change brings back functionality that was present in the retired nfs-client-provisioner and introduced behavioral change. Having folder that includes namespace, pvc name and pv name also in archived state is beneficial and it is what always made this provisioner different from i.e. AzureFile and similar, where you have to browse and search a long time until you get to your desired archived/created folder.

[jackielii]

LGTM. I didn't realised this was changed in the latest version. But this feature was quite useful in the beginning. And sorry I haven't been tracking this closely.

I'd like to hear other reviewers on why this was changed

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackielii, petermicuch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jackielii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yonatankahana]

i think it coming from the naming of the variable pvName. in the initial commit, pvName is actually the folder name and not PersistentVolume.metadata.name as you would think. as you can see from the original commit:

path := volume.Spec.PersistentVolumeSource.NFS.Path
pvName := filepath.Base(path)
oldPath := filepath.Join(mountPath, pvName)
archivePath := filepath.Join(mountPath, "archieved-"+pvName)

when @Bledai add the support reclaim policies (#6) I beleive he thought that he is not changing behavior or getting the expected behavior by changing:

archivePath := filepath.Join(mountPath, "archived-"+pvName)

to:

archivePath := filepath.Join(mountPath, "archived-"+volume.Name)

anyway, lgtm.

[petermicuch]

@jsafrane is it possible to get this one in without review from @ashishranjan738 ? I see him as required reviewer, but usually only @jackielii reacts to commits in this project.

[jsafrane]

/lgtm