Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename master to main #55

Closed
wants to merge 1 commit into from

Conversation

ikarldasan
Copy link

What this PR does / why we need it:
Needed for kubernetes/k8s.io#1597

Which issue(s) this PR fixes (optional, using fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Needed for kubernetes/k8s.io#1597

@k8s-ci-robot k8s-ci-robot requested review from pohly and saad-ali July 1, 2021 10:56
@k8s-ci-robot
Copy link
Contributor

Welcome @ikarldasan!

It looks like this is your first PR to kubernetes-sigs/nfs-ganesha-server-and-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-ganesha-server-and-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 1, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 2, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ikarldasan, spiffxp
To complete the pull request process, please assign saad-ali after the PR has been reviewed.
You can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pohly
Copy link
Contributor

pohly commented Jul 3, 2021

/hold

"release-tools" should not be modified locally. The same change already went into csi-release-tools and will be copied from there.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2021
@spiffxp
Copy link
Member

spiffxp commented Jul 27, 2021

@pohly is there anything we can do to help the copy take place? I notice this and a number of other repos are still pending (ref: kubernetes/k8s.io#1597 (comment))

@pohly
Copy link
Contributor

pohly commented Aug 2, 2021

@pohly is there anything we can do to help the copy take place?

The change was merged into csi-release-tools and component owners are welcome to refresh their copy of the repo - anyone can do that. I just tend to do it myself for kubernetes-csi with a script because it is less work overall.

I notice this and a number of other repos are still pending (ref: kubernetes/k8s.io#1597 (comment))

I already submitted PRs for csi-test and csi-driver-host-path almost a month ago. We just had problems with inactive default reviewers again 😢 I ran my script again now which created new PRs. Perhaps those get more attention.

I didn't update some of the other repos (including this one here) because I didn't know that they were using csi-release-tools and/or whether automatically generated PRs are welcome. I updated my script to also update repos under the kubernetes-sigs org, but ran into issues with "make test" in nfs-subdir-external-provisioner and nfs-ganesha-server-and-external-provisioner. It might just be a Go version mismatch, but I'd prefer if owners of those repos update csi-release-tools themselves because I don't have the bandwidth to deal with repo specific issues.

@consideRatio
Copy link
Contributor

consideRatio commented Aug 2, 2021

"release-tools" should not be modified locally. The same change already went into csi-release-tools and will be copied from there.

I suggest we close this in favor of kubernetes-csi/csi-release-tools#165 that updates this as part of release-tools directly.

@pohly
Copy link
Contributor

pohly commented Aug 2, 2021

"release-tools" should not be modified locally. The same change already went into csi-release-tools and will be copied from there.

I suggest we close this in favor of kubernetes-csi/csi-release-tools#165 that updates this as part of release-tools directly.

That nicely avoids the issue of deciding which branch is the latest.

However, someone still needs to take care of updating nfs-ganesha-server-and-external-provisioner.

@consideRatio
Copy link
Contributor

However, someone still needs to take care of updating nfs-ganesha-server-and-external-provisioner.

@pohly yepp! I opened #58 to address what remains here that can be addressed now and not also require an actual rename of branches. I hope that by doing so, #58 can get merged quickly and then the actual migration work related to CI systems etc referencing specific branches can be done with less trouble.

@consideRatio
Copy link
Contributor

kubernetes-csi/csi-release-tools#165 has been merged!

@consideRatio
Copy link
Contributor

This PR correctly fixes a link, but does it in files that are managed centrally in csi-release-tools, which has got its links fixed at this point via kubernetes-csi/csi-release-tools#165.

Other similar changes for this repo has been made in #58.

Should we close this PR at this point?

@spiffxp
Copy link
Member

spiffxp commented Sep 15, 2021

This repo is still showing up in cs.k8s.io as referencing the old links. What needs to happen to pull in the update of csi-release-tools? Then I think we can close this out

@kvaps
Copy link
Member

kvaps commented Sep 16, 2021

There is another PR which is updating release-tools by the correct way #70

However there are some problems with merging it due to broken OWNER dependencies.

We're waiting for @wongma7 to set correct symlink for OWNERS file before we'll be able to merge it.

@kvaps
Copy link
Member

kvaps commented Sep 17, 2021

Closed in favor #70 (review)
/close

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2021
@k8s-ci-robot
Copy link
Contributor

@ikarldasan: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@kvaps: Closed this PR.

In response to this:

Closed in favor #70 (review)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants