-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master to main #55
Conversation
Welcome @ikarldasan! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ikarldasan, spiffxp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold "release-tools" should not be modified locally. The same change already went into csi-release-tools and will be copied from there. |
@pohly is there anything we can do to help the copy take place? I notice this and a number of other repos are still pending (ref: kubernetes/k8s.io#1597 (comment)) |
The change was merged into csi-release-tools and component owners are welcome to refresh their copy of the repo - anyone can do that. I just tend to do it myself for kubernetes-csi with a script because it is less work overall.
I already submitted PRs for csi-test and csi-driver-host-path almost a month ago. We just had problems with inactive default reviewers again 😢 I ran my script again now which created new PRs. Perhaps those get more attention. I didn't update some of the other repos (including this one here) because I didn't know that they were using csi-release-tools and/or whether automatically generated PRs are welcome. I updated my script to also update repos under the kubernetes-sigs org, but ran into issues with "make test" in nfs-subdir-external-provisioner and nfs-ganesha-server-and-external-provisioner. It might just be a Go version mismatch, but I'd prefer if owners of those repos update csi-release-tools themselves because I don't have the bandwidth to deal with repo specific issues. |
I suggest we close this in favor of kubernetes-csi/csi-release-tools#165 that updates this as part of release-tools directly. |
That nicely avoids the issue of deciding which branch is the latest. However, someone still needs to take care of updating nfs-ganesha-server-and-external-provisioner. |
@pohly yepp! I opened #58 to address what remains here that can be addressed now and not also require an actual rename of branches. I hope that by doing so, #58 can get merged quickly and then the actual migration work related to CI systems etc referencing specific branches can be done with less trouble. |
kubernetes-csi/csi-release-tools#165 has been merged! |
This PR correctly fixes a link, but does it in files that are managed centrally in csi-release-tools, which has got its links fixed at this point via kubernetes-csi/csi-release-tools#165. Other similar changes for this repo has been made in #58. Should we close this PR at this point? |
This repo is still showing up in cs.k8s.io as referencing the old links. What needs to happen to pull in the update of csi-release-tools? Then I think we can close this out |
Closed in favor #70 (review) |
@ikarldasan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@kvaps: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Needed for kubernetes/k8s.io#1597
Which issue(s) this PR fixes (optional, using fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Needed for kubernetes/k8s.io#1597