Creating new workerStatefulSet instead of patching when updating LWS template #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccomodate change from patch to create on delete
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, Edwinhr716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label tide/merge-method-squash |
liurupeng
added a commit
that referenced
this pull request
Oct 18, 2024
…template (#229) * switched to only creating workerSts if no workerSts exists * added deleteWorkerStatefulSet function * fixed names in test, added delete of workerstatefulset on update to accomodate change from patch to create on delete * cleanup * removed outdated comments * renamed delete function * deleteWorkerStatefulSet only necessary after second update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it
Changes from patching the worker sts to update it, to create a new worker sts when it doesn't exist. The need for this change is described in #225 (comment)
Which issue(s) this PR fixes
Fixes #225
Special notes for your reviewer
Does this PR introduce a user-facing change?