Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executable permission to the example script ray_init.sh #166

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

xgchena
Copy link
Contributor

@xgchena xgchena commented Jun 26, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it

The commit adds "x" permission to the vllm example script ray_init.sh . Without the permission, container startup fails due to error "sh: 1: /vllm-workspace/ ray_init.sh: Permission denied"

Which issue(s) this PR fixes

N/A. I was trying with the vllm example and found that containers failed to start, and logs show that the ray_init.sh was not executed due to permission issue, e.g.,

$ kubectl logs vllm-0  
sh: 1: /vllm-workspace/ray_init.sh: Permission denied
INFO 06-26 08:22:10 api_server.py:151] vLLM API server version 0.4.1
...
2024-06-26 08:22:13,143	INFO worker.py:1749 -- Started a local Ray instance.
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/usr/local/lib/python3.10/dist-packages/vllm/entrypoints/openai/api_server.py", line 159, in <module>
    engine = AsyncLLMEngine.from_engine_args(
  File "/usr/local/lib/python3.10/dist-packages/vllm/engine/async_llm_engine.py", line 352, in from_engine_args
    initialize_ray_cluster(engine_config.parallel_config)
  File "/usr/local/lib/python3.10/dist-packages/vllm/engine/ray_utils.py", line 106, in initialize_ray_cluster
    raise ValueError(
ValueError: The number of required GPUs exceeds the total number of available GPUs in the cluster.

With fix, the model is successfully deployed, and I managed to get inference from it, see below

$ curl http://localhost:8080/v1/completions \
-H "Content-Type: application/json" \
-d '{
    "model": "facebook/opt-125m",
    "prompt": "San Francisco is a",
    "max_tokens": 7,
    "temperature": 0
}'
Handling connection for 8080
{"id":"cmpl-d09542e84246481f97f2efb9d15ad2c7","object":"text_completion","created":1719391009,"model":"facebook/opt-125m","choices":[{"index":0,"text":" great place to live.  I","logprobs":null,"finish_reason":"length","stop_reason":null}],"usage":{"prompt_tokens":5,"total_tokens":12,"completion_tokens":7}}  

Special notes for your reviewer

N/A

Does this PR introduce a user-facing change?

N/A

As the subject, the permission is added by "chmod +x". Without the
permission, container startup fails due to "sh: 1: /vllm-workspace/
ray_init.sh: Permission denied"
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 26, 2024
Copy link

linux-foundation-easycla bot commented Jun 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xgchena / name: Xiaoguang Chen (9c231dd)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xgchena
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kerthcet June 26, 2024 09:00
@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @xgchena!

It looks like this is your first PR to kubernetes-sigs/lws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/lws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 26, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @xgchena. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 26, 2024
Copy link
Contributor

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Please sign the CLA first, thanks!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2024
@ahg-g ahg-g merged commit a4c468e into kubernetes-sigs:main Jun 26, 2024
6 of 8 checks passed
@liurupeng
Copy link
Collaborator

@xgchena @kerthcet I didn't see any changes in the PR?

@kerthcet
Copy link
Contributor

It add the permission just like chmod +x.

@liurupeng
Copy link
Collaborator

ah, I see!

@kerthcet
Copy link
Contributor

Kindly ping @xgchena could you sign the CLA to make sure we're following the conduct of Kubernetes community? I believe it wouldn't take too much time, if you have any problem, feel free to ping/DM me. Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants