-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add executable permission to the example script ray_init.sh #166
Add executable permission to the example script ray_init.sh #166
Conversation
As the subject, the permission is added by "chmod +x". Without the permission, container startup fails due to "sh: 1: /vllm-workspace/ ray_init.sh: Permission denied"
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xgchena The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @xgchena! |
Hi @xgchena. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Please sign the CLA first, thanks!
It add the permission just like |
ah, I see! |
Kindly ping @xgchena could you sign the CLA to make sure we're following the conduct of Kubernetes community? I believe it wouldn't take too much time, if you have any problem, feel free to ping/DM me. Thanks very much! |
What type of PR is this?
/kind bug
What this PR does / why we need it
The commit adds "x" permission to the vllm example script ray_init.sh . Without the permission, container startup fails due to error "sh: 1: /vllm-workspace/ ray_init.sh: Permission denied"
Which issue(s) this PR fixes
N/A. I was trying with the vllm example and found that containers failed to start, and logs show that the ray_init.sh was not executed due to permission issue, e.g.,
With fix, the model is successfully deployed, and I managed to get inference from it, see below
Special notes for your reviewer
N/A
Does this PR introduce a user-facing change?
N/A