tests: demonstrate issue with JSON patch when base adds name prefix #971
Conversation
| version: v1 | ||
| kind: Service | ||
| name: myService # BUG: this should be a-myService, because that is what the output for the base contains | ||
| path: service-patch.yaml |
There was a problem hiding this comment.
Not sure if I fully understand, the test fails if name is myService, and you expect name to be set to a-myService?
There was a problem hiding this comment.
The test passes as it is written now. But I consider that a bug (see #972) and would expect the test to pass with name: a-myService instead.
There was a problem hiding this comment.
This is great. Can you add a reference to 972 in the comment, or better yet in the name of the test?
The expectation is that the base entity can be referenced by its name with prefix, because the overlay shouldn't have to know how the base is generated. But currently the entity is only found when using the name without prefix. Related-To: kubernetes-sigs#972
dc3376f to
403ede7
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pohly If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Jeff Regan <notifications@github.com> writes:
Can you add a reference to 972 in the comment, or better yet in the
name of the test?
Chicken-and-egg problem ;-) First came the test and PR, then the issue report.
I've updated the code and the commit message, both link to the issue now.
|
|
yay, thanks /lgtm |
The expectation is that the base entity can be referenced by its name
with prefix, because the overlay shouldn't have to know how the base
is generated. But currently the entity is only found when using the
name without prefix.