Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhooks to order list of gvk #822

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Add webhooks to order list of gvk #822

merged 1 commit into from
Feb 27, 2019

Conversation

Liujingfang1
Copy link
Contributor

Fix #821
Add MutatingWebhookConfiguration and ValidatingWebhookConfiguration right after CustomResourceDefinition.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2019
@monopole
Copy link
Contributor

sure, why not :)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit d5c8734 into kubernetes-sigs:master Feb 27, 2019
@donbowman
Copy link
Contributor

This commit does not resolve the issue.
This commit doesn't even add a test case from the one in the issue.

@donbowman donbowman mentioned this pull request Mar 1, 2019
Closed
@anguslees anguslees mentioned this pull request Mar 5, 2019
Closed
@Liujingfang1 Liujingfang1 deleted the webhooks branch April 4, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengqiy mengqiy Awaiting requested review from mengqiy

@pwittrock pwittrock Awaiting requested review from pwittrock

@monopole monopole Awaiting requested review from monopole

Assignees

@monopole monopole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Liujingfang1 @k8s-ci-robot @monopole @donbowman