Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update owners file #5518

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Update owners file #5518

merged 1 commit into from
Jan 25, 2024

Conversation

natasha41575
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 25, 2024
@natasha41575 natasha41575 requested review from ncapps and koba1t January 25, 2024 17:50
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 25, 2024
@natasha41575
Copy link
Contributor Author

/cc @annasong20 @varshaprasad96 @stormqueen1990 @ncapps @koba1t

@natasha41575
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@annasong20
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@stormqueen1990
Copy link
Member

stormqueen1990 commented Jan 25, 2024 via email

varshaprasad96
varshaprasad96 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koba1t
Copy link
Member

koba1t commented Jan 25, 2024

I appreciate your long contribution and helpful advice!
/lgtm

@natasha41575
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit dd49bd4 into kubernetes-sigs:master Jan 25, 2024
9 checks passed
@natasha41575 natasha41575 deleted the updateowners branch January 25, 2024 22:05
@koba1t koba1t mentioned this pull request Jan 31, 2024
Merged
@natasha41575 natasha41575 mentioned this pull request Feb 7, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@ncapps ncapps Awaiting requested review from ncapps

@koba1t koba1t Awaiting requested review from koba1t

@annasong20 annasong20 Awaiting requested review from annasong20

@stormqueen1990 stormqueen1990 Awaiting requested review from stormqueen1990

Assignees

@stormqueen1990 stormqueen1990

@koba1t koba1t

@annasong20 annasong20

@varshaprasad96 varshaprasad96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@natasha41575 @annasong20 @stormqueen1990 @k8s-ci-robot @koba1t @varshaprasad96