Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running docs site with docker #5512

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix running docs site with docker #5512

merged 4 commits into from
Jan 31, 2024

Conversation

ncapps
Copy link
Contributor

@ncapps ncapps commented Jan 19, 2024

Resolves #5331

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2024
@ncapps ncapps marked this pull request as ready for review January 19, 2024 01:43
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2024
@ncapps
Copy link
Contributor Author

ncapps commented Jan 19, 2024

Hi @stormqueen1990 , Thanks for the k/website references. I will definitely refer to that repository in the future.

Would you please take a look at this PR when you get a chance?

@stormqueen1990
Copy link
Member

Hi @stormqueen1990 , Thanks for the k/website references. I will definitely refer to that repository in the future.

Would you please take a look at this PR when you get a chance?

Hey there @ncapps! Sure thing! I'm running a little behind but will give it a try and fully review this PR before Tuesday next week.

Thanks for working on this!

stormqueen1990
stormqueen1990 reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few outstanding questions 🙂
Didn't get a chance to test it yet, will do soon.

Thanks for working on this!

@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ncapps
Copy link
Contributor Author

ncapps commented Jan 26, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 26, 2024
@ncapps ncapps requested a review from stormqueen1990 January 26, 2024 02:44
stormqueen1990
stormqueen1990 reviewed Jan 26, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a try and the Docker variant works for me. Good work here 🎉

@ncapps
Copy link
Contributor Author

ncapps commented Jan 26, 2024

Hi @stormqueen1990, Thank you for your review and feedback! I believe I updated everything per your comments. Let me know if you would like additional changes.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
@ncapps
Copy link
Contributor Author

ncapps commented Jan 26, 2024

/remove-approve

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2024
stormqueen1990
stormqueen1990 reviewed Jan 27, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work here! 😄

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2024
@stormqueen1990
Copy link
Member

/cc @varshaprasad96

for approval since we have changes to a file in the API folder

ncapps added 4 commits January 30, 2024 17:22
@ncapps
Update docs site local build
37713c4 
Clean up makefile

Ignore container-image.sentinel

Fix hugo server errors

Ignore files

Add makefile credit
@ncapps
Indentation per feedback
d8c8307
@ncapps
Address PR feedback. Remove sentinel file
7523f21
@ncapps
Remove change to .gitignore
b5de5b9
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@ncapps
Copy link
Contributor Author

ncapps commented Jan 31, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncapps

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@ncapps
Copy link
Contributor Author

ncapps commented Jan 31, 2024 •
edited
Loading

Hi @stormqueen1990, Would you please add a lgtm when you get a chance? I rebased this branch with the lint error fix and this change is now limited to the site directory.

stormqueen1990
stormqueen1990 reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@stormqueen1990 stormqueen1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for this 😃

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit add367b into kubernetes-sigs:master Jan 31, 2024
9 checks passed
antoooks pushed a commit to antoooks/kustomize that referenced this pull request Feb 13, 2024
@ncapps @antoooks
Fix running docs site with docker (kubernetes-sigs#5512)
81b0862 
* Update docs site local build

Clean up makefile

Ignore container-image.sentinel

Fix hugo server errors

Ignore files

Add makefile credit

* Indentation per feedback

* Address PR feedback. Remove sentinel file

* Remove change to .gitignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormqueen1990 stormqueen1990 stormqueen1990 left review comments

@natasha41575 natasha41575 Awaiting requested review from natasha41575

@yuwenma yuwenma Awaiting requested review from yuwenma

@koba1t koba1t Awaiting requested review from koba1t

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@stormqueen1990 stormqueen1990

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
Kustomize Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site building guide for docker results in an error
3 participants
@ncapps @k8s-ci-robot @stormqueen1990