Fix typo in merge2 #5489
Fix typo in merge2 #5489
Conversation
|
|
|
Welcome @ltearno! |
|
Hi @ltearno. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -45,9 +45,9 @@ func MergeStrings(srcStr, destStr string, infer bool, mergeOptions yaml.MergeOpt | |||
| } | |||
|
|
|||
| type Merger struct { | |||
| // for forwards compatibility when new functions are added to the interface | |||
There was a problem hiding this comment.
I feel this comment means that when we need to add some field in this struct.
So, I think this comment is still in the right place.
There was a problem hiding this comment.
Hi @koba1t , and thanks for your review! I think I disagree with you on your point:
As far as I understand, the comment is applying to the pattern that is used to ensure that if functions are added to the walk.Visitor interface, the struct will still implement all of them (if not, the build will failed because of the line var _ walk.Visitor = Merger{}).
And also the comment refers to the interface, which Merger is not (it is a struct), so again, the comment should apply to the line mentioned above.
So if a new function is added on the walk.Visitor interface, the line var _ walk.Visitor = Merger{} will ensure that the Merger struct is still (forward-)compatible with the interface, which is basically what the comment is saying.
WDYT?
There was a problem hiding this comment.
Oh, Thanks for describing this code. I misunderstood walk.Visitor as not an interface.
I agree with what you are doing now.
|
Hi @ltearno I added a comment with my thoughts. |
|
Thanks for your contribution! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: koba1t, ltearno The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The moved comment obviously is associated with the code that enshures
MergerimplementsVisitor