fix: add lock for kubernetesOpenAPIVersion

[pmalek]

Ideally we'd introduce a fully fledged fix that avoids usage of globals but that might be more involved hence this simple fix.

Partially fixes: #4824.

[k8s-ci-robot]

Welcome @pmalek!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @pmalek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[koba1t]

Hi @pmalek.
Thanks for your contribution!

I think we need to check in the test whether #4824 is fixed.
Could you add test cases to check that problem is fixed?

/cc @KnVerey

[pmalek]

Hi @pmalek. Thanks for your contribution!

I think we need to check in the test whether #4824 is fixed. Could you add test cases to check that problem is fixed?

Hi @koba1t 👋

What we're trying to test here is a data race which is tricky to deterministically ensure in tests.

I can submit a test that would spin 2 (or more?) goroutines which would call SetSchema/ResetOpenAPI for a while and verify that it didn't panic but in order for this to make sense we'd need to add a -race flag to go test command invocation. I'd assume this is the relevant one:

kustomize/kyaml/Makefile

Line 36 in 4fc0249

go test -v -cover ./...

Can you give some guidance on this?

[koba1t]

Hi @pmalek!

That is the right line to edit the test flag.

Can you give some guidance on this?

I think we just edit the kyaml/Makefile file.

[KnVerey]

/ok-to-test

[pmalek]

I've added a test that tests this (to an extent possible). I'm not particularly fond of this solution but hey! it helps with the data race problem.

[KnVerey]

/approve

Thanks for adding a test! I confirmed that it fails pretty reliably on master; it just needs a real name, please. :)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, pmalek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• kyaml/OWNERS [KnVerey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KnVerey]

/lgtm

[KnVerey]

The test failures are unrelated and fixed by #4995

[koba1t]

/lgtm

Could you try to rebase master to fix test failures?

[pmalek]

/lgtm

Could you try to rebase master to fix test failures?

Done

[KnVerey]

I'm so sorry, but an external change caused another failure on master that was fixed in #5004 . Can you please rebase one last time? I swear this isn't normal. 😅

[pmalek]

I'm so sorry, but an external change caused another failure on master that was fixed in #5004 . Can you please rebase one last time? I swear this isn't normal. 😅

No worries 🙃 Done.

[KnVerey]

/lgtm

[emirot]

@pmalek why partially ?

[pmalek]

@emirot Partially because IMHO there should be no need to use globals.

On top of that as I look at this now there are places where globalSchema is accessed without a lock: e.g. in

kustomize/kyaml/openapi/openapi.go

Line 318 in ed09399

func AddDefinitions(definitions spec.Definitions) {