Bump k8s.io/kube-openapi to remove archived dependency #4965
Conversation
1b68ec7 to
2dba1ee
Compare
|
/lgtm |
|
/assign @KnVerey |
There was a problem hiding this comment.
For the record the diff is kubernetes/kube-openapi@b28bf28...3758b55. Since whatever k/k is using for this dependency is canonical for us too, and our tests pass, I'm not concerned.
| require golang.org/x/mod v0.4.2 | ||
|
|
||
| require golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect | ||
| require golang.org/x/mod v0.7.0 |
There was a problem hiding this comment.
Is this bump related somehow?
| @@ -8,32 +8,29 @@ require ( | |||
| github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 | |||
| github.com/imdario/mergo v0.3.6 | |||
| github.com/pkg/errors v0.9.1 | |||
| github.com/stretchr/testify v1.8.0 | |||
| github.com/stretchr/testify v1.8.1 | |||
There was a problem hiding this comment.
Is this bump related somehow? Usually we want each dep in its own PR, but in this case I don't mind too much because testify is a tests-only dep.
|
Yes @KnVerey, the only command I passed was: The other modules that were upgraded in the process ( |
Bump k8s.io/kube-openapi to remove archived dependency github.com/PuerkitoBio/urlesc
2dba1ee to
aaf9d39
Compare
|
@KnVerey I just rebased on master, because of merge conflicts. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, olivierlemasle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump
k8s.io/kube-openapito remove archived dependencygithub.com/PuerkitoBio/urlescFixes #4962