-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow path starting with slash #4947
feat: Allow path starting with slash #4947
Conversation
|
Hi @Azhovan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @Azhovan! |
@KnVerey @natasha41575 |
/assign @phanimarupaka |
@phanimarupaka @mortent |
/ok-to-test |
/lgtm |
/approve Thanks for the contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Azhovan, KnVerey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Problem :
I started using
Transformer Configurations
with the following spec:directory structure:
➜ cat kustomization.yaml
➜ cat resource.yaml
➜ cat namespace.yaml
I noticed when
path
innamespace.yaml
starts with a slash i.e/metadata/namespace
PathSplitter function returns a slice of strings where first element is an empty string, causing kustomize to return an error like this, when I ran:kustomize build .
in root of the directory.
handling this forward slash at the beginning of a
path
seems to make working with kustomize easier