Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip adding nameprefix to namespace #239

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

Liujingfang1
Copy link
Contributor

Fix #235

@Liujingfang1 Liujingfang1 requested review from droot and monopole August 8, 2018 17:49
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Liujingfang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2018
@Liujingfang1
Copy link
Contributor Author

@droot, as I remember, we also encountered this problem when creating the kustomization for kubebuilder project. We put a comment about the nameprefix. https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/scaffold/project/kustomize.go#L60
With this change, namespace declared in kustomization.yaml will be independent with prefix.

This change has another impact on kubebuilder project. The namespace in generated manager.yaml should match the namespace in kustomization.yaml. https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/scaffold/manager/config.go#L48 Not sure if this is a good change in kubebuilder.

Or we allow kustomize to create a namespace resource that is not found from resources or bases.

Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3857a67 into kubernetes-sigs:master Aug 8, 2018
@droot
Copy link
Contributor

droot commented Aug 8, 2018

Ouch... this will break kubebuilder generated Kustomizations. Can we have some sort of deprecation in place ?

@myok12
Copy link

myok12 commented Jan 12, 2019

Is there a plan to fix this (again)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants