-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip adding nameprefix to namespace #239
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Liujingfang1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@droot, as I remember, we also encountered this problem when creating the kustomization for kubebuilder project. We put a comment about the nameprefix. https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/scaffold/project/kustomize.go#L60 This change has another impact on kubebuilder project. The namespace in generated manager.yaml should match the namespace in kustomization.yaml. https://github.com/kubernetes-sigs/controller-tools/blob/master/pkg/scaffold/manager/config.go#L48 Not sure if this is a good change in kubebuilder. Or we allow kustomize to create a namespace resource that is not found from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ouch... this will break kubebuilder generated Kustomizations. Can we have some sort of deprecation in place ? |
Is there a plan to fix this (again)? |
Fix #235