Add --reorder flag. #1171
Merged
Add --reorder flag. #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds
--reorder {none | legacy }flag to thebuildcommand.The default value is
legacywhich means no change - continue to output resources in the legacy order (Namespaces first, ValidatingWebhookConfiguration last, etc. - seegvk.go)A value of
nonesuppresses the sort (however, the output order is at the moment indeterminate under certain conditions - working on this).The goal is to let users use a transformer plugin to get whatever final order they want, but this means suppressing the legacy sort (hence this PR) and retaining a predictable order throughout generation/transformation stages (still working on this, and #756 #821)